Sign upLogin

activemerchant/active_merchant

View on GitHub
Star

Showing 977 of 1,450 total issues

Consider simplifying this complex logical expression.
Open

        if  (options.dig(:stored_credential, :initial_transaction) && options.dig(:stored_credential, :initiator) == 'cardholder') ||
            (payment.respond_to?(:verification_value) && payment.verification_value && options.dig(:stored_credential, :initial_transaction).nil?) ||
            payment.is_a?(NetworkTokenizationCreditCard)
          shopper_interaction = 'Ecommerce'
        else
Severity: Major
Found in lib/active_merchant/billing/gateways/adyen.rb - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

            if response['refusalReason'] && response['additionalData'] && response['additionalData']['refusalReasonRaw']
          "#{response['refusalReason']} | #{response['additionalData']['refusalReasonRaw']}"
        else
          response['refusalReason'] || response['resultCode'] || response['message'] || response['result']
        end
    Severity: Major
    Found in lib/active_merchant/billing/gateways/adyen.rb - About 40 mins to fix

      Method log_with_retry_details has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def log_with_retry_details(logger, attempts, time, message, tag)
      Severity: Minor
      Found in lib/active_merchant/network_connection_retries.rb - About 35 mins to fix

        Method response has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def response(action, succeeded, response, options = {}, source_id = nil)
        Severity: Minor
        Found in lib/active_merchant/billing/gateways/checkout_v2.rb - About 35 mins to fix

          Method commit has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def commit(action, post, options, authorization = nil, method = :post)
          Severity: Minor
          Found in lib/active_merchant/billing/gateways/checkout_v2.rb - About 35 mins to fix

            Method add_auth_invoice_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def add_auth_invoice_data(action, post, money, authorization, options)
            Severity: Minor
            Found in lib/active_merchant/billing/gateways/cecabank/cecabank_json.rb - About 35 mins to fix

              Method generate_hash_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def generate_hash_data(order_id, terminal_id, credit_card_number, amount, security_data)
              Severity: Minor
              Found in lib/active_merchant/billing/gateways/garanti.rb - About 35 mins to fix

                Method add_address has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def add_address(xml, creditcard, address, options, shipTo = false)
                Severity: Minor
                Found in lib/active_merchant/billing/gateways/quantum.rb - About 35 mins to fix

                  Method add_transaction_details has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def add_transaction_details(xml, amount, authorization, type, options = {})
                  Severity: Minor
                  Found in lib/active_merchant/billing/gateways/creditcall.rb - About 35 mins to fix

                    Method build_authorized_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          def build_authorized_request(action, money, authorization, credit_card, options)
                    Severity: Minor
                    Found in lib/active_merchant/billing/gateways/mercury.rb - About 35 mins to fix

                      Method add_auth_purchase_params has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def add_auth_purchase_params(post, money, card, action, options)
                      Severity: Minor
                      Found in lib/active_merchant/billing/gateways/d_local.rb - About 35 mins to fix

                        Method add_address has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                              def add_address(post, payment_method, address, options, address_type)
                        Severity: Minor
                        Found in lib/active_merchant/billing/gateways/cyber_source_rest.rb - About 35 mins to fix

                          Method add_reference has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                def add_reference(post, orderid, transactionid, transaction_reference, reference_key = :reference)
                          Severity: Minor
                          Found in lib/active_merchant/billing/gateways/mastercard.rb - About 35 mins to fix

                            Method add_customerdetails has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                  def add_customerdetails(xml, creditcard, address, options, shipTo = false)
                            Severity: Minor
                            Found in lib/active_merchant/billing/gateways/iridium.rb - About 35 mins to fix

                              Method add_cim_auth_purchase has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                    def add_cim_auth_purchase(xml, transaction_type, amount, payment, options)
                              Severity: Minor
                              Found in lib/active_merchant/billing/gateways/authorize_net.rb - About 35 mins to fix

                                Method add_auth_purchase has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                      def add_auth_purchase(xml, transaction_type, amount, payment, options)
                                Severity: Minor
                                Found in lib/active_merchant/billing/gateways/authorize_net.rb - About 35 mins to fix

                                  Method api_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                        def api_request(action, request, verb, payment_method_details, options)
                                  Severity: Minor
                                  Found in lib/active_merchant/billing/gateways/blue_snap.rb - About 35 mins to fix

                                    Method commit has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                          def commit(action, options, verb = :post, payment_method_details = PaymentMethodDetails.new(), &block)
                                    Severity: Minor
                                    Found in lib/active_merchant/billing/gateways/blue_snap.rb - About 35 mins to fix

                                      Method build_field_value_array has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                            def build_field_value_array(soap, tag_name, type, custom_data, fields)
                                      Severity: Minor
                                      Found in lib/active_merchant/billing/gateways/usa_epay_advanced.rb - About 35 mins to fix

                                        Method build_void_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                              def build_void_request(money, transaction_id, approval, token, options)
                                        Severity: Minor
                                        Found in lib/active_merchant/billing/gateways/jetpay.rb - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language