activescaffold/active_scaffold

View on GitHub

Showing 246 of 296 total issues

Method render_embedded has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def render_embedded(options)
      require 'digest/md5'

      remote_controller = options[:active_scaffold]
      # It is important that the EID hash remains short as to not contribute
Severity: Minor
Found in lib/active_scaffold/extensions/action_view_rendering.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method active_scaffold_search_datetime_field has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def active_scaffold_search_datetime_field(column, options, current_search, name, ui_options: column.options)
        options = ui_options.merge(options)
        type = "#{'date' unless options[:discard_date]}#{'time' unless options[:discard_time]}"
        field_name = "#{options[:name]}[#{name}]"
        if options[:use_select]
Severity: Minor
Found in lib/active_scaffold/helpers/search_column_helpers.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(model_id)
      super
      return unless ActiveScaffold::Bridges::DatePicker.default_ui

      types = %i[date datetime timestamp timestamptz]
Severity: Minor
Found in lib/active_scaffold/bridges/date_picker/ext.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method with_unsaved_associated has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def with_unsaved_associated(&block)
    associations_for_update.map do |assoc|
      association_proxy = association(assoc.name)
      if association_proxy.target.present?
        records = association_proxy.target
Severity: Minor
Found in lib/active_scaffold/extensions/unsaved_associated.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method active_scaffold_file_with_remove_link has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def active_scaffold_file_with_remove_link(column, options, content, remove_file_prefix, controls_class, ui_options: column.options, &block)
Severity: Minor
Found in lib/active_scaffold/helpers/form_column_helpers.rb - About 45 mins to fix

    Function update_column has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          update_column: function(element, url, send_form, source_id, val, additional_params) {
    Severity: Minor
    Found in app/assets/javascripts/jquery/active_scaffold.js - About 45 mins to fix

      Method column_heading_value has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def column_heading_value(column, sorting, sort_direction)
              if column.name == :as_marked
                mark_column_heading
              elsif column.sortable?
                options = {id: nil, class: 'as_sort',
      Severity: Minor
      Found in lib/active_scaffold/helpers/list_column_helpers.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method responds_to_parent has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def responds_to_parent(&block)
            yield
            return unless performed?
      
            # Either pull out a redirect or the request body
      Severity: Minor
      Found in lib/active_scaffold/responds_to_parent.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method active_scaffold_refresh_link has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def active_scaffold_refresh_link(column, html_options, record, ui_options = {})
              link_options = {object: record}
              if html_options['data-update_url']
                link_options['data-update_send_form'] = html_options['data-update_send_form']
                link_options['data-update_send_form_selector'] = html_options['data-update_send_form_selector']
      Severity: Minor
      Found in lib/active_scaffold/helpers/form_column_helpers.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method format_for_datetime has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def format_for_datetime(column, value, ui_name, ui_options)
            format = I18n.t "time.formats.#{ui_options[:format] || :picker}", default: '' if ui_name == :datetime_picker
            return super if format.blank?
      
            parts = Date._parse(value)
      Severity: Minor
      Found in lib/active_scaffold/bridges/date_picker/ext.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method record_for_update_column has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def record_for_update_column
            @record = find_if_allowed(params[:id], :read)
            raise ActiveScaffold::ActionNotAllowed unless @record.authorized_for?(crud_type: :update, column: @column.name)
      
            if @column.delegated_association
      Severity: Minor
      Found in lib/active_scaffold/actions/update.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method do_edit_associated has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def do_edit_associated
            @scope = params[:scope]
            @parent_record = params[:id].nil? ? new_parent_record : find_if_allowed(params[:id], :update)
      
            cache_generated_id(@parent_record, params[:generated_id]) if @parent_record.new_record?
      Severity: Minor
      Found in lib/active_scaffold/actions/subform.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method do_add_existing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def do_add_existing
            parent_record = nested_parent_record(:update)
            @record = active_scaffold_config.model.find(params[:associated_id])
            if parent_record && @record
              self.successful = false unless parent_record.send(nested.association.name) << @record
      Severity: Minor
      Found in lib/active_scaffold/actions/nested.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method current_form_columns has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def current_form_columns(record, scope, subform_controller = nil)
              if scope
                subform_controller.active_scaffold_config.subform.columns.visible_columns_names
              elsif %i[new create edit update render_field].include? action_name.to_sym
                # disable update_columns for inplace_edit (GET render_field)
      Severity: Minor
      Found in lib/active_scaffold/helpers/form_column_helpers.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method nested_chain_with_association has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def nested_chain_with_association
            if nested.association.collection?
              nested_parent_record.send(nested.association.name)
            elsif nested.association.through? # has_one :through
              active_scaffold_config.model.where(active_scaffold_config.model.primary_key => nested_parent_record.send(nested.association.name)&.id)
      Severity: Minor
      Found in lib/active_scaffold/actions/nested.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method format_number_value has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def format_number_value(value, options = {})
              if value
                value =
                  case options[:format]
                  when :size
      Severity: Minor
      Found in lib/active_scaffold/helpers/list_column_helpers.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                  options[:size] ||= options[:maxlength].to_i > 30 ? 30 : options[:maxlength]
      Severity: Major
      Found in lib/active_scaffold/helpers/form_column_helpers.rb - About 45 mins to fix

        Method reverse_association has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def reverse_association(klass = nil)
              assoc =
                if polymorphic?
                  get_reverse(klass) unless klass.nil?
                else
        Severity: Minor
        Found in lib/active_scaffold/data_structures/association/abstract.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method delete_group has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def delete_group(name)
              @set.each do |group|
                next unless group.is_a?(ActiveScaffold::DataStructures::ActionLinks)
        
                if group.name == name
        Severity: Minor
        Found in lib/active_scaffold/data_structures/action_links.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method readonly_through_association? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def readonly_through_association?(columns)
              return false unless through_association?
              return true if association.through_reflection.options[:through] # create not possible, too many levels
              return true if association.source_reflection.options[:through] # create not possible, too many levels
              return false if create_through_singular? # create allowed, AS has code for this
        Severity: Minor
        Found in lib/active_scaffold/data_structures/nested_info.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language