Sign upLogin

ad2games/soapy_cake

View on GitHub
Star

Showing 4 of 4 total issues

Class Admin has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Admin < Client
    include Helper

    def affiliate_bills(opts = {})
      run Request.new(:admin, :accounting, :export_affiliate_bills, opts)
Severity: Minor
Found in lib/soapy_cake/admin.rb - About 4 hrs to fix

    Class AdminAddedit has 24 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class AdminAddedit < Client
    include Helper

    OFFER_DEFAULT_OPTIONS = {
      offer_name: '',
    Severity: Minor
    Found in lib/soapy_cake/admin_addedit.rb - About 2 hrs to fix

      Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def run(request)
      check_write_enabled!(request)
      request.api_key = api_key
      request.time_converter = time_converter
      Severity: Minor
      Found in lib/soapy_cake/client.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method xml_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def xml_params(xml, opts)
      opts.each do |key, value|
        if value.is_a?(Array)
          xml['cake'].public_send(key) { value.each { |v| xml_params(xml, v) } }
        elsif value.is_a?(Hash)
      Severity: Minor
      Found in lib/soapy_cake/request.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language