adam-26/react-html-metadata

View on GitHub

Showing 2 of 10 total issues

Function update has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Confirmed

    update(previousMetadata, newMetadata) {
        if (this.isServerRender()) {
            // don't update on initial client render or on the server render.
            return null;
        }
Severity: Minor
Found in src/Metadata.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Confirmed

    update(previousMetadata, newMetadata) {
        if (this.isServerRender()) {
            // don't update on initial client render or on the server render.
            return null;
        }
Severity: Minor
Found in src/Metadata.js - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language