Sign upLogin

adam-26/react-router-dispatcher

View on GitHub
Star
src/RouteDispatcher.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function isDispatchActionsEqual has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Confirmed

function isDispatchActionsEqual(arr1, arr2) {
    // Determine if a function was passed.
    const isFunc1 = typeof arr1 === 'function';
    const isFunc2 = typeof arr2 === 'function';
    if (isFunc1 || isFunc2) {
Severity: Minor
Found in src/RouteDispatcher.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isDispatchActionsEqual has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Confirmed

function isDispatchActionsEqual(arr1, arr2) {
    // Determine if a function was passed.
    const isFunc1 = typeof arr1 === 'function';
    const isFunc2 = typeof arr2 === 'function';
    if (isFunc1 || isFunc2) {
Severity: Minor
Found in src/RouteDispatcher.js - About 1 hr to fix

    Function render has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        render() {
        const {
            location,
            routes,
            render,
    Severity: Minor
    Found in src/RouteDispatcher.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Wontfix

          return true;
      Severity: Major
      Found in src/RouteDispatcher.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Wontfix

                            return false;
        Severity: Major
        Found in src/RouteDispatcher.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Wontfix

                          return false;
          Severity: Major
          Found in src/RouteDispatcher.js - About 30 mins to fix

            Function componentWillReceiveProps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Wontfix

                componentWillReceiveProps(nextProps) {
      const { location, actionNames } = this.props;
      const { location: nextLocation, actionNames: nextActionNames } = nextProps;

      let nextState;
            Severity: Minor
            Found in src/RouteDispatcher.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status