adam-26/react-router-dispatcher

View on GitHub
src/withActions.js

Summary

Maintainability
A
45 mins
Test Coverage

Function withActions has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

export default function withActions(mapParamsToProps, ...actions) {
    if (!(typeof mapParamsToProps === 'undefined' || mapParamsToProps === null)) {
        invariant(typeof mapParamsToProps === 'function', '"mapParamsToProps" must be either a function, or null.');
    }

Severity: Major
Found in src/withActions.js - About 5 hrs to fix

    Function withActions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Confirmed

    export default function withActions(mapParamsToProps, ...actions) {
        if (!(typeof mapParamsToProps === 'undefined' || mapParamsToProps === null)) {
            invariant(typeof mapParamsToProps === 'function', '"mapParamsToProps" must be either a function, or null.');
        }
    
    
    Severity: Minor
    Found in src/withActions.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status