adamrenklint/asimov-static

View on GitHub
__tests/parsers/StyleSheetParser.test.js

Summary

Maintainability
F
4 days
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

          test.it('should register the model as a dependency of the nested stylesheet', function () {

            var model = new Model({
              'path': 'foo/bar',
              'raw': '@import "includer"'
Severity: Major
Found in __tests/parsers/StyleSheetParser.test.js and 3 other locations - About 1 day to fix
__tests/parsers/StyleSheetParser.test.js on lines 67..89
__tests/parsers/StyleSheetParser.test.js on lines 91..112
__tests/parsers/StyleSheetParser.test.js on lines 140..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 226.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        test.it('should handle also handle single quotes', function () {

          var model = new Model({
            'path': 'foo/bar',
            'raw': "@import 'foo'"
Severity: Major
Found in __tests/parsers/StyleSheetParser.test.js and 3 other locations - About 1 day to fix
__tests/parsers/StyleSheetParser.test.js on lines 67..89
__tests/parsers/StyleSheetParser.test.js on lines 91..112
__tests/parsers/StyleSheetParser.test.js on lines 116..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 226.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        test.it('should register the model as a node of the stylus file in the dependency graph', function () {

          var model = new Model({
            'path': 'foo/bar',
            'raw': '@import "foo"'
Severity: Major
Found in __tests/parsers/StyleSheetParser.test.js and 3 other locations - About 1 day to fix
__tests/parsers/StyleSheetParser.test.js on lines 67..89
__tests/parsers/StyleSheetParser.test.js on lines 116..137
__tests/parsers/StyleSheetParser.test.js on lines 140..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 226.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        test.it('should add itself to the dependency graph', function () {

          var model = new Model({
            'path': 'foo/bar',
            'raw': '@import "foo"\n@import "bar"'
Severity: Major
Found in __tests/parsers/StyleSheetParser.test.js and 3 other locations - About 1 day to fix
__tests/parsers/StyleSheetParser.test.js on lines 91..112
__tests/parsers/StyleSheetParser.test.js on lines 116..137
__tests/parsers/StyleSheetParser.test.js on lines 140..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 226.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status