adobe/brackets

View on GitHub

Showing 1,485 of 3,294 total issues

Avoid deeply nested control flow statements.
Open

                                    if ( !status && s.isLocal && !s.crossDomain ) {
                                        status = responses.text ? 200 : 404;
                                    // IE - #1450: sometimes returns 1223 when it should be 204
                                    } else if ( status === 1223 ) {
                                        status = 204;

    Avoid deeply nested control flow statements.
    Open

                            if (_prefType !== _initialType) {
                                _prefType = _initialType;
                            }
    Severity: Major
    Found in src/extensions/default/DebugCommands/main.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if ( !old ) {
                              context.setAttribute( "id", nid );
                          } else {
                              nid = nid.replace( /'/g, "\\$&" );
                          }

        Avoid deeply nested control flow statements.
        Open

                                            if ( xhrOnUnloadAbort ) {
                                                delete xhrCallbacks[ handle ];
                                            }

          Avoid deeply nested control flow statements.
          Open

                              if ( typeof cur !== "string" ) {
                                  if ( elem === cur ) {
                                      match = true;
                                      break;
                                  }

            Avoid deeply nested control flow statements.
            Open

                                                if ( xml && xml.documentElement /* #4958 */ ) {
                                                    responses.xml = xml;
                                                }

              Avoid deeply nested control flow statements.
              Open

                                  if ( tmp[ 0 ] === prev || tmp[ 0 ] === "*" ) {
                                      conv2 = converters[ tmp[1] + " " + current ];
                                      if ( conv2 ) {
                                          conv1 = converters[ conv1 ];
                                          if ( conv1 === true ) {

                Avoid deeply nested control flow statements.
                Open

                                            if (pref && pref.type === "object") {
                                                result = _.extend({}, pref.initial, result);
                                            }
                Severity: Major
                Found in src/preferences/PreferencesBase.js - About 45 mins to fix

                  Function showOpenDialog has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      function showOpenDialog(allowMultipleSelection, chooseDirectories, title, initialPath, fileTypes, callback) {
                  Severity: Minor
                  Found in src/filesystem/impls/appshell/AppshellFileSystem.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                            if ($next.length) {
                                                result = {
                                                    where: ABOVEVIEW,
                                                    which: $next
                                                };
                    Severity: Major
                    Found in src/project/WorkingSetView.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          } else if (mouseIsInTopHalf($view)) {
                                              // we're inside the top half of
                                              //  a view so prepend to the view we hit
                                              result = {
                                                  where: ABOVEVIEW,
                      Severity: Major
                      Found in src/project/WorkingSetView.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                        if (doc.isDirty) {
                                                            editConflicts.push({doc: doc, fileTime: fileTime});
                                                        } else {
                                                            toReload.push(doc);
                                                        }
                        Severity: Major
                        Found in src/project/FileSyncManager.js - About 45 mins to fix

                          Function render has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              function render(element, viewModel, projectRoot, actions, forceRender, platform) {
                          Severity: Minor
                          Found in src/project/FileTreeView.js - About 45 mins to fix

                            Function deprecateEvent has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                function deprecateEvent(outbound, inbound, oldEventName, newEventName, canonicalOutboundName, canonicalInboundName) {
                            Severity: Minor
                            Found in src/utils/DeprecationWarning.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                                  if (err) {
                                                                      console.log("Cannot move unreadable preferences file " + path + " to trash!!");
                                                                  } else {
                                                                      console.log("Brackets has recreated the unreadable preferences file " + path + ". You may refer to the deleted file in trash in case you need it!!");
                                                                  }
                              Severity: Major
                              Found in src/preferences/PreferencesBase.js - About 45 mins to fix

                                Function _generateMatchList has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    function _generateMatchList(query, str, originalQuery, originalStr, specials, startingSpecial) {
                                Severity: Minor
                                Found in src/utils/StringMatch.js - About 45 mins to fix

                                  Function _wholeStringSearch has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      function _wholeStringSearch(queryLower, compareLower, originalQuery, originalStr, specials, lastSegmentSpecialsIndex) {
                                  Severity: Minor
                                  Found in src/utils/StringMatch.js - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                                    if (doc.isDirty) {
                                                                        deleteConflicts.push({doc: doc, fileTime: -1});
                                                                    } else {
                                                                        toClose.push(doc);
                                                                    }
                                    Severity: Major
                                    Found in src/project/FileSyncManager.js - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                                  if (ghostIsBelow($hit)) {
                                                                      return result;
                                                                  }
                                      Severity: Major
                                      Found in src/project/WorkingSetView.js - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                                if (pane.id !== _activePaneId) {
                                                                    // activate the pane which will put focus in the pane's doc
                                                                    setActivePaneId(pane.id);
                                                                    // reset the focus to the inline editor
                                                                    current.focus();
                                        Severity: Major
                                        Found in src/view/MainViewManager.js - About 45 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language