adobe/brackets

File Menus.js has 786 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),

Function addMenuItem has 100 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    Menu.prototype.addMenuItem = function (command, keyBindings, position, relativeID) {
        var menuID = this.id,
            id,
            $menuItem,
            menuItem,

Function open has 57 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    ContextMenu.prototype.open = function (mouseOrLocation) {

        if (!this.parentMenuItem &&
           (!mouseOrLocation || !mouseOrLocation.hasOwnProperty("pageX") || !mouseOrLocation.hasOwnProperty("pageY"))) {
            console.error("ContextMenu open(): missing required parameter");

Function _getRelativeMenuItem has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    Menu.prototype._getRelativeMenuItem = function (relativeID, position) {
        var $relativeElement;

        if (relativeID) {
            if (position === FIRST_IN_SECTION || position === LAST_IN_SECTION) {

Function addMenu has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function addMenu(name, id, position, relativeID) {
        name = _.escape(name);
        var $menubar = $("#titlebar .nav"),
            menu;

Function addSubMenu has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    Menu.prototype.addSubMenu = function (name, id, position, relativeID) {

        if (!name || !id) {
            console.error("addSubMenu(): missing required parameters: name and id");
            return null;

Function removeMenuDivider has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    Menu.prototype.removeMenuDivider = function (menuItemID) {
        var menuItem,
            $HTMLMenuItem;

        if (!menuItemID) {

Function removeSubMenu has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    Menu.prototype.removeSubMenu = function (subMenuID) {
        var subMenu,
            parentMenuItem,
            commandID = "";

Function removeMenu has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function removeMenu(id) {
        var menu,
            commandID = "";

        if (!id) {

Function removeMenuItem has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    Menu.prototype.removeMenuItem = function (command) {
        var menuItemID,
            commandID;

        if (!command) {

Avoid too many return statements within this function.

Open

        return menuItem;

Avoid too many return statements within this function.

Open

            return null;

Avoid too many return statements within this function.

Open

            return;

Avoid too many return statements within this function.

Open

        return $relativeElement;

Avoid too many return statements within this function.

Open

            return $relativeElement;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        _.forEach(menuItemMap, function (value, key) {
            if (_.startsWith(key, subMenuID)) {
                if (value.isDivider) {
                    subMenu.removeMenuDivider(key);
                } else {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        _.forEach(menuItemMap, function (value, key) {
            if (_.startsWith(key, id)) {
                if (value.isDivider) {
                    menu.removeMenuDivider(key);
                } else {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            var elementRect = {
                top:    posTop,
                left:   posLeft,
                height: $menuWindow.height() + 25,
                width:  $menuWindow.width()

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            var elementRect = {
                top:    posTop,
                left:   posLeft,
                height: $menuWindow.height() + 25,
                width:  $menuWindow.width()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (_isHTMLMenu(this.id)) {
            // Targeting parent to get the menu item <a> and the <li> that contains it
            $(_getHTMLMenuItem(menuItemID)).parent().remove();
        } else {
            brackets.app.removeMenuItem(commandID, function (err) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (_isHTMLMenu(id)) {
            $(_getHTMLMenu(id)).remove();
        } else {
            brackets.app.removeMenu(id, function (err) {
                if (err) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    Menu.prototype.closeSubMenu = function() {
        if (this.openSubMenu) {
            this.openSubMenu.close();
            this.openSubMenu = null;
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            brackets.app.setMenuItemState(this._command.getID(), enabled, checked, function (err) {
                if (err) {
                    console.log("Error setting menu item state: " + err);
                }
            });

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            brackets.app.setMenuItemState(this._command.getID(), enabled, checked, function (err) {
                if (err) {
                    console.log("Error setting menu item state: " + err);
                }
            });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (clip.bottom > 0) {
                posTop = Math.max(0, posTop + $parentMenuItem.height() - $menuWindow.height());
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (clip.right > 0) {
                posLeft = Math.max(0, posLeft - $parentMenuItem.outerWidth() - $menuWindow.outerWidth());
            }

• Read up
  Read up