adobe/brackets

View on GitHub
src/editor/CodeHintManager.js

Summary

Maintainability
C
1 day
Test Coverage

File CodeHintManager.js has 317 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Minor
Found in src/editor/CodeHintManager.js - About 3 hrs to fix

    Function _updateHintList has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function _updateHintList(callMoveUpEvent) {
    
            callMoveUpEvent = typeof callMoveUpEvent === "undefined" ? false : callMoveUpEvent;
    
            if (deferredHints) {
    Severity: Minor
    Found in src/editor/CodeHintManager.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if (!(event.ctrlKey || event.altKey || event.metaKey) &&
                      (event.keyCode === KeyEvent.DOM_VK_ENTER ||
                       event.keyCode === KeyEvent.DOM_VK_RETURN ||
                       event.keyCode === KeyEvent.DOM_VK_TAB)) {
                  lastChar = String.fromCharCode(event.keyCode);
      Severity: Major
      Found in src/editor/CodeHintManager.js - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                return providers.filter(function (provider) {
                    var prefKey = "codehint." + provider.provider.constructor.name;
                    return PreferencesManager.get(prefKey) !== false;
                });
        Severity: Major
        Found in src/editor/CodeHintManager.js and 1 other location - About 1 hr to fix
        src/features/PriorityBasedRegistration.js on lines 130..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    for (index = 0; index < providers.length; index++) {
                        if (providers[index].provider === provider) {
                            providers.splice(index, 1);
                            break;
                        }
        Severity: Major
        Found in src/editor/CodeHintManager.js and 1 other location - About 1 hr to fix
        src/features/PriorityBasedRegistration.js on lines 114..119

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                enabledProviders.some(function (item, index) {
                    if (item.provider.hasHints(editor, lastChar)) {
                        sessionProvider = item.provider;
                        return true;
                    }
        Severity: Minor
        Found in src/editor/CodeHintManager.js and 1 other location - About 50 mins to fix
        src/features/ParameterHintsManager.js on lines 266..271

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else if (event.keyCode === KeyEvent.DOM_VK_LEFT ||
                               event.keyCode === KeyEvent.DOM_VK_RIGHT ||
                               event.keyCode === KeyEvent.DOM_VK_BACK_SPACE) {
                        // Update the list after a simple navigation.
                        // We do this in "keyup" because we want the cursor position to be updated before
        Severity: Minor
        Found in src/editor/CodeHintManager.js and 1 other location - About 35 mins to fix
        src/extensions/default/InlineColorEditor/ColorEditor.js on lines 446..458

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status