adobe/brackets

View on GitHub
src/editor/EditorCommandHandlers.js

Summary

Maintainability
F
5 days
Test Coverage

File EditorCommandHandlers.js has 703 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Major
Found in src/editor/EditorCommandHandlers.js - About 1 day to fix

    Function _getBlockCommentPrefixSuffixEdit has 174 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function _getBlockCommentPrefixSuffixEdit(editor, prefix, suffix, linePrefixes, sel, selectionsToTrack, command) {
            var doc            = editor.document,
                ctx            = TokenUtils.getInitialContext(editor._codeMirror, {line: sel.start.line, ch: sel.start.ch}),
                selEndIndex    = editor.indexFromPos(sel.end),
                lineExp        = _createLineExpressions(linePrefixes, prefix, suffix),
    Severity: Major
    Found in src/editor/EditorCommandHandlers.js - About 6 hrs to fix

      Function moveLine has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function moveLine(editor, direction) {
              editor = editor || EditorManager.getFocusedEditor();
              if (!editor) {
                  return;
              }
      Severity: Major
      Found in src/editor/EditorCommandHandlers.js - About 3 hrs to fix

        Function _getLineCommentPrefixEdit has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function _getLineCommentPrefixEdit(editor, prefixes, blockPrefix, blockSuffix, lineSel) {
                var doc         = editor.document,
                    sel         = lineSel.selectionForEdit,
                    trackedSels = lineSel.selectionsToTrack,
                    lineExp     = _createLineExpressions(prefixes, blockPrefix, blockSuffix),
        Severity: Major
        Found in src/editor/EditorCommandHandlers.js - About 2 hrs to fix

          Function openLine has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function openLine(editor, direction) {
                  editor = editor || EditorManager.getFocusedEditor();
                  if (!editor) {
                      return;
                  }
          Severity: Minor
          Found in src/editor/EditorCommandHandlers.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                        if (isBlockComment) {
                            // Save the initial position to start searching for the suffix from here
                            initialPos = _.cloneDeep(ctx.pos);
            
                            // Find the position of the start of the prefix
            Severity: Critical
            Found in src/editor/EditorCommandHandlers.js - About 1 hr to fix

              Function duplicateText has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function duplicateText(editor) {
                      editor = editor || EditorManager.getFocusedEditor();
                      if (!editor) {
                          return;
                      }
              Severity: Minor
              Found in src/editor/EditorCommandHandlers.js - About 1 hr to fix

                Function _getBlockCommentPrefixSuffixEdit has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    function _getBlockCommentPrefixSuffixEdit(editor, prefix, suffix, linePrefixes, sel, selectionsToTrack, command) {
                Severity: Major
                Found in src/editor/EditorCommandHandlers.js - About 50 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                              if (sel.end.line === totalLines - 1) {
                                                  nextText += "\n";
                                              }
                  Severity: Major
                  Found in src/editor/EditorCommandHandlers.js - About 45 mins to fix

                    Function _isPrevTokenABlockComment has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        function _isPrevTokenABlockComment(ctx, prefix, suffix, prefixExp, suffixExp, lineExp) {
                    Severity: Minor
                    Found in src/editor/EditorCommandHandlers.js - About 45 mins to fix

                      Function _getLineCommentPrefixSuffixEdit has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          function _getLineCommentPrefixSuffixEdit(editor, prefix, suffix, lineSel, command) {
                      Severity: Minor
                      Found in src/editor/EditorCommandHandlers.js - About 35 mins to fix

                        Function _getLineCommentPrefixEdit has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            function _getLineCommentPrefixEdit(editor, prefixes, blockPrefix, blockSuffix, lineSel) {
                        Severity: Minor
                        Found in src/editor/EditorCommandHandlers.js - About 35 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          if (prefixIndented) {
                                              editGroup.push({text: "", start: {line: prefixPos.line, ch: 0}, end: {line: prefixPos.line + 1, ch: 0}});
                                          } else if (prefixAtStart && suffixAtStart) {
                                              editGroup.push({text: "", start: prefixPos, end: {line: prefixPos.line + 1, ch: 0}});
                                          } else {
                          Severity: Major
                          Found in src/editor/EditorCommandHandlers.js and 1 other location - About 4 hrs to fix
                          src/editor/EditorCommandHandlers.js on lines 570..576

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 116.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                              if (suffixIndented) {
                                                  editGroup.push({text: "", start: {line: suffixPos.line, ch: 0}, end: {line: suffixPos.line + 1, ch: 0}});
                                              } else if (prefixAtStart && suffixAtStart) {
                                                  editGroup.push({text: "", start: suffixPos, end: {line: suffixPos.line + 1, ch: 0}});
                                              } else {
                          Severity: Major
                          Found in src/editor/EditorCommandHandlers.js and 1 other location - About 4 hrs to fix
                          src/editor/EditorCommandHandlers.js on lines 580..586

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 116.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          while (result && !ctx.token.string.match(suffixExp)) {
                                              result = TokenUtils.moveSkippingWhitespace(TokenUtils.moveNextToken, ctx);
                                          }
                          Severity: Minor
                          Found in src/editor/EditorCommandHandlers.js and 1 other location - About 40 mins to fix
                          src/editor/EditorCommandHandlers.js on lines 428..430

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 49.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          while (result && !ctx.token.string.match(prefixExp)) {
                                              result = TokenUtils.moveSkippingWhitespace(TokenUtils.movePrevToken, ctx);
                                          }
                          Severity: Minor
                          Found in src/editor/EditorCommandHandlers.js and 1 other location - About 40 mins to fix
                          src/editor/EditorCommandHandlers.js on lines 439..441

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 49.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                              searchCtx      = TokenUtils.getInitialContext(editor._codeMirror, {line: ctx.pos.line, ch: ctx.token.start});
                          Severity: Minor
                          Found in src/editor/EditorCommandHandlers.js and 1 other location - About 35 mins to fix
                          src/editor/EditorCommandHandlers.js on lines 412..412

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                              searchCtx = TokenUtils.getInitialContext(editor._codeMirror, {line: ctx.pos.line, ch: ctx.token.start});
                          Severity: Minor
                          Found in src/editor/EditorCommandHandlers.js and 1 other location - About 35 mins to fix
                          src/editor/EditorCommandHandlers.js on lines 395..395

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status