adobe/brackets

View on GitHub
src/extensibility/ExtensionManagerDialog.js

Summary

Maintainability
F
3 days
Test Coverage

Function _showDialog has 223 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function _showDialog() {
        var dialog,
            $dlg,
            views   = [],
            $search,
Severity: Major
Found in src/extensibility/ExtensionManagerDialog.js - About 1 day to fix

    File ExtensionManagerDialog.js has 451 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
     * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
     *
     * Permission is hereby granted, free of charge, to any person obtaining a
     * copy of this software and associated documentation files (the "Software"),
    Severity: Minor
    Found in src/extensibility/ExtensionManagerDialog.js - About 6 hrs to fix

      Function _performChanges has 126 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function _performChanges() {
              // If an extension was removed or updated, prompt the user to quit Brackets.
              var hasRemovedExtensions    = ExtensionManager.hasExtensionsToRemove(),
                  hasUpdatedExtensions    = ExtensionManager.hasExtensionsToUpdate(),
                  hasDisabledExtensions   = ExtensionManager.hasExtensionsToDisable();
      Severity: Major
      Found in src/extensibility/ExtensionManagerDialog.js - About 5 hrs to fix

        Function _installUsingDragAndDrop has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function _installUsingDragAndDrop() {
                var installZips = [],
                    updateZips = [],
                    deferred = new $.Deferred(),
                    validatePromise;
        Severity: Major
        Found in src/extensibility/ExtensionManagerDialog.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                          if (errorObj.error && errorObj.error.forEach) {
                                              console.error("Errors for", errorObj.item);
                                              errorObj.error.forEach(function (error) {
                                                  console.error(Package.formatError(error));
                                              });
          Severity: Major
          Found in src/extensibility/ExtensionManagerDialog.js and 1 other location - About 1 hr to fix
          src/extensibility/ExtensionManager.js on lines 825..832

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                                      dialogs.push({
                                          dialog: DefaultDialogs.DIALOG_ID_ERROR,
                                          title: Strings.EXTENSION_MANAGER_UPDATE,
                                          message: StringUtils.format(Strings.EXTENSION_MANAGER_UPDATE_ERROR, ids.join(", "))
                                      });
          Severity: Major
          Found in src/extensibility/ExtensionManagerDialog.js and 2 other locations - About 1 hr to fix
          src/extensibility/ExtensionManagerDialog.js on lines 158..162
          src/extensibility/ExtensionManagerDialog.js on lines 193..197

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                                      dialogs.push({
                                          dialog: DefaultDialogs.DIALOG_ID_ERROR,
                                          title: Strings.EXTENSION_MANAGER_DISABLE,
                                          message: StringUtils.format(Strings.EXTENSION_MANAGER_DISABLE_ERROR, ids.join(", "))
                                      });
          Severity: Major
          Found in src/extensibility/ExtensionManagerDialog.js and 2 other locations - About 1 hr to fix
          src/extensibility/ExtensionManagerDialog.js on lines 158..162
          src/extensibility/ExtensionManagerDialog.js on lines 181..185

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                                      dialogs.push({
                                          dialog: DefaultDialogs.DIALOG_ID_ERROR,
                                          title: Strings.EXTENSION_MANAGER_REMOVE,
                                          message: StringUtils.format(Strings.EXTENSION_MANAGER_REMOVE_ERROR, ids.join(", "))
                                      });
          Severity: Major
          Found in src/extensibility/ExtensionManagerDialog.js and 2 other locations - About 1 hr to fix
          src/extensibility/ExtensionManagerDialog.js on lines 181..185
          src/extensibility/ExtensionManagerDialog.js on lines 193..197

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status