Sign upLogin

adobe/brackets

View on GitHub
Star
src/extensibility/Package.js

Summary

Maintainability
C
1 day
Test Coverage

File Package.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Minor
Found in src/extensibility/Package.js - About 3 hrs to fix

    Function installFromURL has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function installFromURL(url) {
        var STATE_DOWNLOADING = 1,
            STATE_INSTALLING = 2,
            STATE_SUCCEEDED = 3,
            STATE_FAILED = 4;
    Severity: Minor
    Found in src/extensibility/Package.js - About 1 hr to fix

      Function install has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function install(path, nameHint, _doUpdate) {
        return _extensionManagerCall(function (extensionManager) {
            var d                       = new $.Deferred(),
                destinationDirectory    = ExtensionLoader.getUserExtensionPath(),
                disabledDirectory       = destinationDirectory.replace(/\/user$/, "/disabled"),
      Severity: Minor
      Found in src/extensibility/Package.js - About 1 hr to fix

        Function download has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function download(url, downloadId) {
        return _extensionManagerCall(function (extensionManager) {
            var d = new $.Deferred();

            // Validate URL
        Severity: Minor
        Found in src/extensibility/Package.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var InstallationStatuses = {
        FAILED: "FAILED",
        INSTALLED: "INSTALLED",
        ALREADY_INSTALLED: "ALREADY_INSTALLED",
        SAME_VERSION: "SAME_VERSION",
          Severity: Minor
          Found in src/extensibility/Package.js and 1 other location - About 30 mins to fix
          src/extensibility/node/ExtensionManagerDomain.js on lines 49..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status