Sign upLogin

adobe/brackets

View on GitHub
Star
src/extensibility/node/ExtensionManagerDomain.js

Summary

Maintainability
F
5 days
Test Coverage

Function init has 171 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function init(domainManager) {
    if (!domainManager.hasDomain("extensionManager")) {
        domainManager.registerDomain("extensionManager", {major: 0, minor: 1});
    }
    domainManager.registerCommand(
Severity: Major
Found in src/extensibility/node/ExtensionManagerDomain.js - About 6 hrs to fix

    File ExtensionManagerDomain.js has 418 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
    Severity: Minor
    Found in src/extensibility/node/ExtensionManagerDomain.js - About 6 hrs to fix

      Function _cmdInstall has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
      Open

      function _cmdInstall(packagePath, destinationDirectory, options, callback, pCallback, _doUpdate) {
    if (!options || !options.disabledDirectory || !options.apiVersion || !options.systemExtensionDirectory) {
        callback(new Error(Errors.MISSING_REQUIRED_OPTIONS), null);
        return;
    }
      Severity: Minor
      Found in src/extensibility/node/ExtensionManagerDomain.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _cmdInstall has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function _cmdInstall(packagePath, destinationDirectory, options, callback, pCallback, _doUpdate) {
    if (!options || !options.disabledDirectory || !options.apiVersion || !options.systemExtensionDirectory) {
        callback(new Error(Errors.MISSING_REQUIRED_OPTIONS), null);
        return;
    }
      Severity: Major
      Found in src/extensibility/node/ExtensionManagerDomain.js - About 2 hrs to fix

        Function validateCallback has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function validateCallback(err, validationResult) {
        validationResult.localPath = packagePath;

        // This is a wrapper for the callback that will delete the temporary
        // directory to which the package was unzipped.
        Severity: Major
        Found in src/extensibility/node/ExtensionManagerDomain.js - About 2 hrs to fix

          Function _cmdDownloadFile has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function _cmdDownloadFile(downloadId, url, proxy, callback, pCallback) {
    // Backwards compatibility check, added in 0.37
    if (typeof proxy === "function") {
        callback = proxy;
        proxy = undefined;
          Severity: Minor
          Found in src/extensibility/node/ExtensionManagerDomain.js - About 1 hr to fix

            Function _cmdInstall has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function _cmdInstall(packagePath, destinationDirectory, options, callback, pCallback, _doUpdate) {
            Severity: Minor
            Found in src/extensibility/node/ExtensionManagerDomain.js - About 45 mins to fix

              Function _cmdDownloadFile has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function _cmdDownloadFile(downloadId, url, proxy, callback, pCallback) {
              Severity: Minor
              Found in src/extensibility/node/ExtensionManagerDomain.js - About 35 mins to fix

                Function _cmdUpdate has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function _cmdUpdate(packagePath, destinationDirectory, options, callback, pCallback) {
                Severity: Minor
                Found in src/extensibility/node/ExtensionManagerDomain.js - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      domainManager.registerCommand(
        "extensionManager",
        "update",
        _cmdUpdate,
        true,
                  Severity: Major
                  Found in src/extensibility/node/ExtensionManagerDomain.js and 1 other location - About 6 hrs to fix
                  src/extensibility/node/ExtensionManagerDomain.js on lines 490..534

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 172.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      domainManager.registerCommand(
        "extensionManager",
        "install",
        _cmdInstall,
        true,
                  Severity: Major
                  Found in src/extensibility/node/ExtensionManagerDomain.js and 1 other location - About 6 hrs to fix
                  src/extensibility/node/ExtensionManagerDomain.js on lines 535..579

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 172.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  var Statuses = {
    FAILED: "FAILED",
    INSTALLED: "INSTALLED",
    ALREADY_INSTALLED: "ALREADY_INSTALLED",
    SAME_VERSION: "SAME_VERSION",
                  Severity: Minor
                  Found in src/extensibility/node/ExtensionManagerDomain.js and 1 other location - About 30 mins to fix
                  src/extensibility/Package.js on lines 57..65

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status