adobe/brackets

View on GitHub
src/extensions/default/CSSCodeHints/main.js

Summary

Maintainability
D
2 days
Test Coverage

Function getHints has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    CssPropHints.prototype.getHints = function (implicitChar) {
        this.cursor = this.editor.getCursorPos();
        this.info = CSSUtils.getInfoAtPos(this.editor, this.cursor);

        var needle = this.info.name,
Severity: Major
Found in src/extensions/default/CSSCodeHints/main.js - About 3 hrs to fix

    Function insertHint has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        CssPropHints.prototype.insertHint = function (hint) {
            var offset = this.info.offset,
                cursor = this.editor.getCursorPos(),
                start = {line: -1, ch: -1},
                end = {line: -1, ch: -1},
    Severity: Major
    Found in src/extensions/default/CSSCodeHints/main.js - About 2 hrs to fix

      File main.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
       * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
       *
       * Permission is hereby granted, free of charge, to any person obtaining a
       * copy of this software and associated documentation files (the "Software"),
      Severity: Minor
      Found in src/extensions/default/CSSCodeHints/main.js - About 2 hrs to fix

        Avoid too many return statements within this function.
        Open

                        return null;
        Severity: Major
        Found in src/extensions/default/CSSCodeHints/main.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return {
                          hints: formatHints(result, needle),
                          match: null, // the CodeHintManager should not format the results
                          selectInitial: selectInitial,
                          handleWideResults: false
          Severity: Major
          Found in src/extensions/default/CSSCodeHints/main.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return null;
            Severity: Major
            Found in src/extensions/default/CSSCodeHints/main.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  function formatHints(hints, query) {
                      var hasColorSwatch = hints.some(function (token) {
                          return token.color;
                      });
              
              
              Severity: Major
              Found in src/extensions/default/CSSCodeHints/main.js and 1 other location - About 1 day to fix
              src/extensions/default/SVGCodeHints/main.js on lines 104..134

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 239.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          result = $.map(valueArray, function (pvalue) {
                              var result = StringMatch.stringMatch(pvalue.text || pvalue, valueNeedle, stringMatcherOptions);
                              if (result) {
                                  if (pvalue.color) {
                                      result.color = pvalue.color;
              Severity: Major
              Found in src/extensions/default/CSSCodeHints/main.js and 1 other location - About 1 hr to fix
              src/extensions/default/SVGCodeHints/main.js on lines 233..242

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (this.info.context !== CSSUtils.PROP_NAME && this.info.context !== CSSUtils.PROP_VALUE) {
                          return false;
                      }
              Severity: Minor
              Found in src/extensions/default/CSSCodeHints/main.js and 1 other location - About 35 mins to fix
              src/extensions/default/CSSCodeHints/main.js on lines 158..160

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (this.info.context !== CSSUtils.PROP_NAME && this.info.context !== CSSUtils.PROP_VALUE) {
                          return false;
                      }
              Severity: Minor
              Found in src/extensions/default/CSSCodeHints/main.js and 1 other location - About 35 mins to fix
              src/extensions/default/CSSCodeHints/main.js on lines 386..388

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status