adobe/brackets

View on GitHub
src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js

Summary

Maintainability
C
1 day
Test Coverage

Function getRange has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function getRange(cm, start) {
        var currentLine = start.line,
            text = cm.getLine(currentLine) || "",
            i = 0,
            tagStack = [],
Severity: Major
Found in src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js - About 3 hrs to fix

    Function scanTextUntil has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function scanTextUntil(cm, startCh, startLine, condition) {
            var line = cm.getLine(startLine),
                seen = "",
                characterIndex = startCh,
                currentLine = startLine,
    Severity: Minor
    Found in src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              if (tag[0] === "#" || tag[0] === "~" || tag[0] === "^") {
                                  tagStack.push(tag.substr(1));
                              } else if (tag[0] === "/" &&
                                         (_.last(tagStack) === tag.substr(1) || _.last(tagStack) === "*" + tag.substr(1))) {
                                  tagStack.pop();
      Severity: Major
      Found in src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (text[i + 1] === "}") {
                            braceStack.pop();
                            if (braceStack.length === 0 && tagStack.length === 0) {
                                range = {
                                    from: openPos.to,
        src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js on lines 156..168

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                } else if (tag[0] === "/" &&
                                           (_.last(tagStack) === tag.substr(1) || _.last(tagStack) === "*" + tag.substr(1))) {
                                    tagStack.pop();
                                    if (tagStack.length === 0 && braceStack.length === 0) {
                                        range = {
        src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js on lines 173..182

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (condition(seen)) {
                                range = {
                                    from: {ch: startCh, line: startLine},
                                    to: {ch: characterIndex, line: currentLine},
                                    string: seen
        src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js on lines 56..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (condition(seen)) {
                            range = {
                                from: {ch: startCh, line: startLine},
                                to: {ch: characterIndex, line: currentLine},
                                string: seen
        src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js on lines 65..72

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status