adobe/brackets

View on GitHub
src/extensions/default/HTMLCodeHints/main.js

Summary

Maintainability
D
1 day
Test Coverage

File main.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Minor
Found in src/extensions/default/HTMLCodeHints/main.js - About 4 hrs to fix

    Function getHints has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        AttrHints.prototype.getHints = function (implicitChar) {
            var cursor = this.editor.getCursorPos(),
                query = {queryStr: null},
                tokenType,
                offset,
    Severity: Major
    Found in src/extensions/default/HTMLCodeHints/main.js - About 2 hrs to fix

      Function insertHint has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          AttrHints.prototype.insertHint = function (completion) {
              var cursor = this.editor.getCursorPos(),
                  start = {line: -1, ch: -1},
                  end = {line: -1, ch: -1},
                  tokenType = this.tagInfo.position.tokenType,
      Severity: Major
      Found in src/extensions/default/HTMLCodeHints/main.js - About 2 hrs to fix

        Function hasHints has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            AttrHints.prototype.hasHints = function (editor, implicitChar) {
                var pos = editor.getCursorPos(),
                    tokenType,
                    offset,
                    query;
        Severity: Major
        Found in src/extensions/default/HTMLCodeHints/main.js - About 2 hrs to fix

          Avoid deeply nested control flow statements.
          Open

                              if (hints instanceof Array) {
                                  // If we got synchronous hints, check if we have something we'll actually use
                                  var i, foundPrefix = false;
                                  for (i = 0; i < hints.length; i++) {
                                      if (hints[i].indexOf(query) === 0) {
          Severity: Major
          Found in src/extensions/default/HTMLCodeHints/main.js - About 45 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (start.ch !== end.ch) {
                            this.editor.document.replaceRange(completion, start, end);
                        } else {
                            this.editor.document.replaceRange(completion, start);
                        }
            Severity: Major
            Found in src/extensions/default/HTMLCodeHints/main.js and 2 other locations - About 1 hr to fix
            src/extensions/default/HTMLCodeHints/main.js on lines 535..539
            src/extensions/default/HtmlEntityCodeHints/main.js on lines 255..259

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (start.ch !== end.ch) {
                            this.editor.document.replaceRange(completion, start, end);
                        } else {
                            this.editor.document.replaceRange(completion, start);
                        }
            Severity: Major
            Found in src/extensions/default/HTMLCodeHints/main.js and 2 other locations - About 1 hr to fix
            src/extensions/default/HTMLCodeHints/main.js on lines 186..190
            src/extensions/default/HtmlEntityCodeHints/main.js on lines 255..259

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status