adobe/brackets

View on GitHub
src/extensions/default/JavaScriptCodeHints/main.js

Summary

Maintainability
F
4 days
Test Coverage

File main.js has 520 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Major
Found in src/extensions/default/JavaScriptCodeHints/main.js - About 1 day to fix

    Function getHintResponse has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function getHintResponse(hints, query, type) {
    
            var trimmedQuery,
                formattedHints;
    
    
    Severity: Major
    Found in src/extensions/default/JavaScriptCodeHints/main.js - About 3 hrs to fix

      Function doJumpToDef has 75 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              JSJumpToDefProvider.prototype.doJumpToDef = function () {
                  var offset,
                      handleJumpResponse;
      
      
      
      Severity: Major
      Found in src/extensions/default/JavaScriptCodeHints/main.js - About 3 hrs to fix

        Function formatHints has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function formatHints(hints, query) {
                    return hints.map(function (token) {
                        var $hintObj    = $("<span>").addClass("brackets-js-hints");
        
                        // level indicates either variable scope or property confidence
        Severity: Minor
        Found in src/extensions/default/JavaScriptCodeHints/main.js - About 1 hr to fix

          Function setJumpSelection has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      function setJumpSelection(start, end, isFunction) {
          
                          /**
                           * helper function to decide if the tokens on the RHS of an assignment
                           * look like an identifier, or member expr.
          Severity: Minor
          Found in src/extensions/default/JavaScriptCodeHints/main.js - About 1 hr to fix

            Function getHints has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                JSHints.prototype.getHints = function (key) {
                    var cursor = session.getCursor(),
                        token = session.getToken(cursor);
            
                    if (token && HintUtils.hintableKey(key, !noHintsOnDot) && HintUtils.hintable(token)) {
            Severity: Minor
            Found in src/extensions/default/JavaScriptCodeHints/main.js - About 1 hr to fix

              Function getSessionHints has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function getSessionHints(query, cursor, type, token, $deferredHints) {
              
                      var hintResults = session.getHints(query, getStringMatcher());
                      if (hintResults.needGuesses) {
                          var guessesResponse = ScopeManager.requestGuesses(session,
              Severity: Minor
              Found in src/extensions/default/JavaScriptCodeHints/main.js - About 1 hr to fix

                Function insertHint has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    JSHints.prototype.insertHint = function ($hintObj) {
                        var hint        = $hintObj.data("token"),
                            completion  = hint.value,
                            cursor      = session.getCursor(),
                            query       = session.getQuery(),
                Severity: Minor
                Found in src/extensions/default/JavaScriptCodeHints/main.js - About 1 hr to fix

                  Function formatTypeDataForToken has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          function formatTypeDataForToken($hintObj, token) {
                  
                              if (!hintDetailsEnabled) {
                                  return;
                              }
                  Severity: Minor
                  Found in src/extensions/default/JavaScriptCodeHints/main.js - About 1 hr to fix

                    Function getSessionHints has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        function getSessionHints(query, cursor, type, token, $deferredHints) {
                    Severity: Minor
                    Found in src/extensions/default/JavaScriptCodeHints/main.js - About 35 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if (token.type) {
                                      if (token.type.trim() !== '?') {
                                          if (token.type.length < 30) {
                                              $('<span>' + token.type.split('->').join(':').toString().trim() + '</span>').appendTo($hintObj).addClass("brackets-js-hints-type-details");
                                          }
                      Severity: Major
                      Found in src/extensions/default/JavaScriptCodeHints/main.js and 1 other location - About 1 day to fix
                      src/languageTools/DefaultProviders.js on lines 63..74

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 220.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if (token.doc) {
                                      $hintObj.attr('title', token.doc);
                                      $('<span></span>').text(token.doc.trim()).appendTo($hintObj).addClass("jshint-jsdoc");
                                  }
                      Severity: Major
                      Found in src/extensions/default/JavaScriptCodeHints/main.js and 1 other location - About 1 hr to fix
                      src/languageTools/DefaultProviders.js on lines 75..78

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 69.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status