adobe/brackets

File unittests.js has 1333 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),

Function expectParameterHint has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function expectParameterHint(expectedParams, expectedParameter) {
            var requestHints = undefined,
                request = null;
            
            function expectHint(hint) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        function expectParameterHint(expectedParams, expectedParameter) {
            var requestHints = undefined,
                request = null;
            
            function expectHint(hint) {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should insert, not replace, property hints with no current query", function () {
                var start   = { line: 6, ch: 0 },
                    middle  = { line: 6, ch: 3 },
                    end     = { line: 6, ch: 8 },
                    endplus = { line: 6, ch: 12 };

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should replace property hints replacing a partial current query", function () {
                var start   = { line: 6, ch: 0 },
                    middle  = { line: 6, ch: 6 },
                    end     = { line: 6, ch: 8 },
                    endplus = { line: 6, ch: 10 };

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should replace property hints but not following delimiters", function () {
                var start   = { line: 6, ch: 0 },
                    middle  = { line: 6, ch: 4 },
                    end     = { line: 6, ch: 9 },
                    endplus = { line: 6, ch: 14 };

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should insert property hints with no current query", function () {
                var start   = { line: 6, ch: 0 },
                    middle  = { line: 6, ch: 3 },
                    end     = { line: 6, ch: 8 };

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should insert hint as [\"my-key\"] make sure this works if nothing is typed after the '.'", function () {
                var start = { line: 49, ch: 0 },
                    middle = { line: 49, ch: 4 },
                    end = { line: 49, ch: 13 };

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should insert, not replace, property hints with a partial current query", function () {
                var start   = { line: 6, ch: 0 },
                    middle  = { line: 6, ch: 6 },
                    end     = { line: 6, ch: 8 };

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should insert hint as '.for' since keywords can be used as property names", function () {
                var start = { line: 49, ch: 0 },
                    middle = { line: 49, ch: 5 },
                    end = { line: 49, ch: 7 };

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should insert hint as [\"my-key\"] since 'my-key' is not a valid property name", function () {
                var start = { line: 49, ch: 0 },
                    middle = { line: 49, ch: 5 },
                    end = { line: 49, ch: 13 };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should handle reading an invalid configuration file", function () {
                getPreferences(testPath + "negative-test/.jscodehints");
                waitsFor(function () {
                    return preferences !== null;
                });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should handle reading an empty configuration file", function () {
                getPreferences(testPath + "defaults-test/.jscodehints");
                waitsFor(function () {
                    return preferences !== null;
                });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        function _waitForHints(hintObj, callback) {
            var complete = false,
                hintList = null;

            if (hintObj.hasOwnProperty("hints")) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should close parameter hint when move off function to another function", function () {
                var testPos = { line: 184, ch: 12 },
                    newPos  = { line: 181, ch: 12 };
                testEditor.setCursorPos(testPos);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should close parameter hint when move off function", function () {
                var testPos = { line: 184, ch: 12 },
                    endPos  = { line: 184, ch: 19 };
                testEditor.setCursorPos(testPos);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            _waitForJump(jumpPromise, function (newCursor) {
                expect(newCursor.line).toBe(expectedLocation.line);
                expect(newCursor.ch).toBe(expectedLocation.ch);
                if (expectedLocation.file) {
                    var activeEditor = EditorManager.getActiveEditor();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        function hintsPresentExact(hintObj, expectedHints) {
            _waitForHints(hintObj, function (hintList) {
                expect(hintList).toBeTruthy();
                expect(hintList.length).toBe(expectedHints.length);
                expectedHints.forEach(function (expectedHint, index) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        function _waitForJump(jumpPromise, callback) {
            var cursor = null,
                complete = false;

            jumpPromise.done(function () {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            xit("should read properties from exported module", function () {
                var start        = { line: 96, ch: 0 },
                    testPos          = { line: 96, ch: 9};

                testDoc.replaceRange("hondaCar.", start);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            xit("should read methods created in submodule module", function () {
                var start        = { line: 62, ch: 0 },
                    testPos          = { line: 62, ch: 13};

                testDoc.replaceRange("SearchEngine.", start);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should show argument from from .prototype.Method", function () {
                var start = { line: 80, ch: 0 },
                    testPos = { line: 80, ch: 24 };

                testDoc.replaceRange("myCustomer.setAmountDue(", start);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should show guessed argument type from current passing parameter", function () {
                var start = { line: 80, ch: 0 },
                    testPos = { line: 80, ch: 24 };
                testDoc.replaceRange("myCustomer.setAmountDue(10)", start);
                testEditor.setCursorPos(testPos);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should list function type defined from .prototype", function () {
                var start = { line: 59, ch: 10 };
                testEditor.setCursorPos(start);
                runs(function () {
                    expectParameterHint([{name: "a4", type: "Number"}, {name: "b4", type: "Number"}], 0);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should show function type code hint for function in script file inside html file", function () {
                var start = { line: 22, ch: 17 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should show function type code hint for function in another script file inside html file", function () {
                var start = { line: 23, ch: 17 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        function _indexOf(hintList, hint) {
            var index = -1,
                counter = 0;

            for (counter; counter < hintList.length; counter++) {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            xit("should show hints for members of referenced class", function () {
                var start = { line: 8, ch: 15 };

                runs(function () {
                    testEditor.setCursorPos(start);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            xit("should read methods created in submodule", function () {
                var start = { line: 19, ch: 15 };

                runs(function () {
                    testEditor.setCursorPos(start);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should read methods created in submodule on this", function () {
                var start = { line: 8, ch: 17 };

                runs(function () {
                    testEditor.setCursorPos(start);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should list later defined property names", function () {
                var start = { line: 17, ch: 11 };

                testEditor.setCursorPos(start);
                var hintObj = expectHints(JSCodeHints.jsHintProvider);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should list array containing functions", function () {
                var testPos = { line: 142, ch: 7 };

                testEditor.setCursorPos(testPos);
                var hintObj = expectHints(JSCodeHints.jsHintProvider);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should jump to the actual function definition, and not the exports line", function () {
                var start = { line: 159, ch: 22 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should jump to the definition in new module file", function () {
                var start = { line: 40, ch: 22 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should list parameter hint for an array parameter", function () {
                var testPos = { line: 184, ch: 12 };
                testEditor.setCursorPos(testPos);
                runs(function () {
                    expectParameterHint([{name: "other", type: "Array.<Object>"}], -1);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should list parameter hint for record type annotation", function () {
                var testPos = { line: 178, ch: 25 };

                testEditor.setCursorPos(testPos);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should list parameter hint for a source array annotation", function () {
                var testPos = { line: 200, ch: 20 };
                testEditor.setCursorPos(testPos);
                runs(function () {
                    expectParameterHint([{name: "a", type: "Array.<String>"}], 0);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should show inner function type", function () {
                var testPos = { line: 96, ch: 23 };

                testEditor.setCursorPos(testPos);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("function type hint in html file", function () {
                var start = { line: 36, ch: 12 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to function", function () {
                var start = { line: 43, ch: 0 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to inner method", function () {
                var start = { line: 96, ch: 32 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to closure, early defined var", function () {
                var start = { line: 17, ch: 9 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to parameter passed in the method", function () {
                var start = { line: 63, ch: 20 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to var", function () {
                var start = { line: 44, ch: 10 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to funtion definition to loaded file2", function () {
                var start = { line: 23, ch: 15 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to funtion definition to loaded file1", function () {
                var start = { line: 22, ch: 15 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to parameter passed in anonymous method", function () {
                var start = { line: 83, ch: 25 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to function name with non ascii chars", function () {
                var start        = { line: 16, ch: 12 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to definition inside html file", function () {
                var start = { line: 36, ch: 10 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to property definition to loaded file1", function () {
                var start = { line: 23, ch: 28 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

            it("should jump to property definition to loaded file2", function () {
                var start = { line: 23, ch: 18 };

                testEditor.setCursorPos(start);
                runs(function () {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            _waitForHints(hintObj, function (hintList) {
                expect(hintList).toBeTruthy();
                expectedHints.forEach(function (expectedHint) {
                    expect(_indexOf(hintList, expectedHint)).not.toBe(-1);
                });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should list literal constants", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsPresent(hintObj, ["null", "undefined", "true", "false"]);
            });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it("should list declared variable and function names in outer scope", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsPresent(hintObj, ["A2", "A3", "funB", "A1"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should list keywords", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsPresent(hintObj, ["break", "case", "catch"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should NOT list keywords on property lookups", function () {
                testEditor.setCursorPos({ line: 17, ch: 11 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsAbsent(hintObj, ["case", "function", "var"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should NOT list property names on value lookups", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsAbsent(hintObj, ["propA", "propB", "propC"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should NOT list implicitly defined globals from missing JSLint annotations", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsAbsent(hintObj, ["ActiveXObject", "CScript", "VBArray"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should NOT list implicitly defined globals from JSLint annotations in other files", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsAbsent(hintObj, ["spawn", "version", "toint32"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            xit("should list explicitly defined globals from JSLint annotations", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsPresent(hintObj, ["brackets", "$"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should list identifier names that occur in other files", function () {
                testEditor.setCursorPos({ line: 16, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsPresent(hintObj, ["D1", "D2"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should NOT list variables, function names and parameter names in other files", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsAbsent(hintObj, ["E1", "E2"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should NOT list variables, function names and parameter names out of scope", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsAbsent(hintObj, ["paramB2", "paramB1"]);
            });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

            it("should NOT list explicitly defined globals from JSLint annotations in other files", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsAbsent(hintObj, ["crazyGlobal", "anotherCrazyGlobal"]);
            });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should NOT list string literals from other files", function () {
                testEditor.setCursorPos({ line: 6, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsAbsent(hintObj, ["a very nice string"]);
            });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            it("should list property names that have been declared in the file", function () {
                testEditor.setCursorPos({ line: 17, ch: 11 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsPresent(hintObj, ["propB"]);
            });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            xit("should list string literals that occur in the file", function () {
                testEditor.setCursorPos({ line: 12, ch: 0 });
                var hintObj = expectHints(JSCodeHints.jsHintProvider);
                hintsPresent(hintObj, ["use strict"]);
            });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                runs(function () {
                    testEditor.setCursorPos(testPos);
                    var hintObj = expectHints(JSCodeHints.jsHintProvider);
                    hintsPresentExact(hintObj, ["fun測试()"]);
                });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                runs(function () {
                    testEditor.setCursorPos(start);
                    var hintObj = expectHints(JSCodeHints.jsHintProvider);
                    hintsPresentExact(hintObj, ["fun測试"]);
                });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                runs(function () {
                    testEditor.setCursorPos(start);
                    var hintObj = expectHints(JSCodeHints.jsHintProvider);
                    hintsPresentExact(hintObj, ["frenchçProp()"]);
                });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                identifierList.forEach(function (element) {
                    var result = HintUtils.maybeIdentifier(element);
                    expect(result).toBe(true);
                });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                invalidIdentifierList.forEach(function (element) {
                    var result = HintUtils.maybeIdentifier(element);
                    expect(result).toBe(false);
                });

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

            it("should not list hints in string literal", function () {
                testEditor.setCursorPos({ line: 20, ch: 22 });
                expectNoHints(JSCodeHints.jsHintProvider);
            });

• Read up
  Read up