adobe/brackets

View on GitHub
src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/globalize.js

Summary

Maintainability
F
6 days
Test Coverage

File globalize.js has 1162 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Globalize
 *
 * http://github.com/jquery/globalize
 *

    Function parseFloat has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Globalize.parseFloat = function( value, radix, cultureSelector ) {
        // radix argument is optional
        if ( typeof radix !== "number" ) {
            cultureSelector = radix;
            radix = 10;

      Function findClosestCulture has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Globalize.findClosestCulture = function( name ) {
          var match;
          if ( !name ) {
              return this.cultures[ this.cultureSelector ] || this.cultures[ "default" ];
          }

        Function parseDate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Globalize.parseDate = function( value, formats, culture ) {
            culture = this.findClosestCulture( culture );
        
            var date, prop, patterns;
            if ( formats ) {

          Avoid deeply nested control flow statements.
          Open

                              if ( copyIsArray ) {
                                  copyIsArray = false;
                                  clone = src && isArray(src) ? src : [];
          
                              } else {

            Avoid deeply nested control flow statements.
            Open

                            } else if ( copy !== undefined ) {
                                target[ name ] = copy;
                            }

              Avoid deeply nested control flow statements.
              Open

                                          if ( eraName === cal.eras[i].name.toLowerCase() ) {
                                              era = i;
                                              break;
                                          }

                Avoid deeply nested control flow statements.
                Open

                                    if ( date ) {
                                        break;
                                    }

                  Avoid too many return statements within this function.
                  Open

                                          if ( outOfRange(min, 0, 59) ) return null;

                    Avoid too many return statements within this function.
                    Open

                                if ( result === null ) return null;

                      Avoid too many return statements within this function.
                      Open

                              return ret;

                        Avoid too many return statements within this function.
                        Open

                                return name;

                          Avoid too many return statements within this function.
                          Open

                                                  if ( outOfRange(sec, 0, 59) ) return null;

                            Avoid too many return statements within this function.
                            Open

                                return match || null;

                              Avoid too many return statements within this function.
                              Open

                                                      if ( era === null ) return null;

                                Avoid too many return statements within this function.
                                Open

                                                        ) return null;

                                  Avoid too many return statements within this function.
                                  Open

                                                          if ( outOfRange(weekDay, 0, 6) ) return null;

                                    Avoid too many return statements within this function.
                                    Open

                                                            if ( outOfRange(hour, 0, 23) ) return null;

                                      Avoid too many return statements within this function.
                                      Open

                                                              if ( offsets.length !== 2 ) return null;

                                        Avoid too many return statements within this function.
                                        Open

                                                                if ( outOfRange(hourOffset, -12, 13) ) return null;

                                          Avoid too many return statements within this function.
                                          Open

                                                                  if ( outOfRange(minOffset, 0, 59) ) return null;

                                            Avoid too many return statements within this function.
                                            Open

                                                            return null;

                                              Avoid too many return statements within this function.
                                              Open

                                                                      if ( outOfRange(year, 0, 9999) ) return null;

                                                Avoid too many return statements within this function.
                                                Open

                                                                        if ( !eraName || !cal.eras ) return null;

                                                  Avoid too many return statements within this function.
                                                  Open

                                                                          if ( outOfRange(msec, 0, 999) ) return null;

                                                    Avoid too many return statements within this function.
                                                    Open

                                                            return result;

                                                      Avoid too many return statements within this function.
                                                      Open

                                                                  if ( result.getDate() !== date ) return null;

                                                        Avoid too many return statements within this function.
                                                        Open

                                                                                if ( outOfRange(hour, 0, 11) ) return null;

                                                          Avoid too many return statements within this function.
                                                          Open

                                                                                  if ( outOfRange(hourOffset, -12, 13) ) return null;

                                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                                            Open

                                                            arrayIndexOf = function( array, item ) {
                                                                if ( array.indexOf ) {
                                                                    return array.indexOf( item );
                                                                }
                                                                for ( var i = 0, length = array.length; i < length; i++ ) {
                                                            src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/qunit.js on lines 1591..1603

                                                            Duplicated Code

                                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                            Tuning

                                                            This issue has a mass of 81.

                                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                            Refactorings

                                                            Further Reading

                                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                                            Open

                                                                    currency: {
                                                                        // [negativePattern, positivePattern]
                                                                        //   negativePattern: one of "($n)|-$n|$-n|$n-|(n$)|-n$|n-$|n$-|-n $|-$ n|n $-|$ n-|$ -n|n- $|($ n)|(n $)"
                                                                        //   positivePattern: one of "$n|n$|$ n|n $"
                                                                        pattern: [ "($n)", "$n" ],
                                                            src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/globalize.js on lines 128..144

                                                            Duplicated Code

                                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                            Tuning

                                                            This issue has a mass of 56.

                                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                            Refactorings

                                                            Further Reading

                                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                                            Open

                                                                    percent: {
                                                                        // [negativePattern, positivePattern]
                                                                        //   negativePattern: one of "-n %|-n%|-%n|%-n|%n-|n-%|n%-|-% n|n %-|% n-|% -n|n- %"
                                                                        //   positivePattern: one of "n %|n%|%n|% n"
                                                                        pattern: [ "-n %", "n %" ],
                                                            src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/globalize.js on lines 145..161

                                                            Duplicated Code

                                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                            Tuning

                                                            This issue has a mass of 56.

                                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                            Refactorings

                                                            Further Reading

                                                            Identical blocks of code found in 3 locations. Consider refactoring.
                                                            Open

                                                                var options, name, src, copy, copyIsArray, clone,
                                                                    target = arguments[0] || {},
                                                                    i = 1,
                                                                    length = arguments.length,
                                                                    deep = false;
                                                            src/thirdparty/jquery-2.1.3.js on lines 178..182
                                                            src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/jquery-1.7.2.js on lines 325..329

                                                            Duplicated Code

                                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                            Tuning

                                                            This issue has a mass of 55.

                                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                            Refactorings

                                                            Further Reading

                                                            Identical blocks of code found in 2 locations. Consider refactoring.
                                                            Open

                                                                if ( typeof target === "boolean" ) {
                                                                    deep = target;
                                                                    target = arguments[1] || {};
                                                                    // skip the boolean and the target
                                                                    i = 2;
                                                            src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/jquery-1.7.2.js on lines 332..337

                                                            Duplicated Code

                                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                            Tuning

                                                            This issue has a mass of 51.

                                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                            Refactorings

                                                            Further Reading

                                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                                            Open

                                                                                            !cal.AM || ( matchGroup !== cal.AM[0] && matchGroup !== cal.AM[1] && matchGroup !== cal.AM[2] )
                                                            src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/globalize.js on lines 1116..1116

                                                            Duplicated Code

                                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                            Tuning

                                                            This issue has a mass of 46.

                                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                            Refactorings

                                                            Further Reading

                                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                                            Open

                                                                                    pmHour = cal.PM && ( matchGroup === cal.PM[0] || matchGroup === cal.PM[1] || matchGroup === cal.PM[2] );
                                                            src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/globalize.js on lines 1119..1119

                                                            Duplicated Code

                                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                            Tuning

                                                            This issue has a mass of 46.

                                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                            Refactorings

                                                            Further Reading

                                                            There are no issues that match your filters.

                                                            Category
                                                            Status