Sign upLogin

adobe/brackets

View on GitHub
Star
src/extensions/default/JavaScriptRefactoring/RenameIdentifier.js

Summary

Maintainability
C
1 day
Test Coverage

Function handleRename has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function handleRename() {
        var editor = EditorManager.getActiveEditor(),
            offset, handleFindRefs, token;

        if (!editor) {
Severity: Major
Found in src/extensions/default/JavaScriptRefactoring/RenameIdentifier.js - About 2 hrs to fix

    Function handleFindRefs has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function handleFindRefs (refsResp) {
            if (!refsResp || !refsResp.references || !refsResp.references.refs) {
                return;
            }
    Severity: Minor
    Found in src/extensions/default/JavaScriptRefactoring/RenameIdentifier.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return result.promise();
      Severity: Major
      Found in src/extensions/default/JavaScriptRefactoring/RenameIdentifier.js - About 30 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            var EditorManager        = brackets.getModule("editor/EditorManager"),
        ScopeManager         = brackets.getModule("JSUtils/ScopeManager"),
        Session              = brackets.getModule("JSUtils/Session"),
        MessageIds           = brackets.getModule("JSUtils/MessageIds"),
        TokenUtils           = brackets.getModule("utils/TokenUtils"),
        Severity: Major
        Found in src/extensions/default/JavaScriptRefactoring/RenameIdentifier.js and 2 other locations - About 2 hrs to fix
        src/extensions/default/JavaScriptRefactoring/unittests.js on lines 30..40
        src/extensions/default/OpenWithExternalApplication/GraphicsFile.js on lines 28..34

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    fileInfo = {
                type: MessageIds.TERN_FILE_INFO_TYPE_FULL,
                name: path,
                offsetLines: 0,
                text: ScopeManager.filterText(session.getJavascriptText())
        Severity: Minor
        Found in src/extensions/default/JavaScriptRefactoring/RenameIdentifier.js and 1 other location - About 30 mins to fix
        src/extensions/default/JavaScriptRefactoring/RefactoringUtils.js on lines 205..210

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status