adobe/brackets

View on GitHub
src/extensions/default/JavaScriptRefactoring/WrapSelection.js

Summary

Maintainability
C
1 day
Test Coverage

Function convertToArrowFunction has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function convertToArrowFunction() {
        var editor = EditorManager.getActiveEditor();
        if (!editor) {
            return;
        }
Severity: Major
Found in src/extensions/default/JavaScriptRefactoring/WrapSelection.js - About 3 hrs to fix

    Function createGettersAndSetters has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function createGettersAndSetters() {
            var editor = EditorManager.getActiveEditor();
            if (!editor) {
                return;
            }
    Severity: Major
    Found in src/extensions/default/JavaScriptRefactoring/WrapSelection.js - About 2 hrs to fix

      Function _wrapSelectedStatements has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function _wrapSelectedStatements (wrapperName, err) {
              var editor = EditorManager.getActiveEditor();
              if (!editor) {
                  return;
              }
      Severity: Minor
      Found in src/extensions/default/JavaScriptRefactoring/WrapSelection.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        "fullFunctionScope": {
                            "start": current.cm.posFromIndex(loc.fullFunctionScope.start),
                            "end": current.cm.posFromIndex(loc.fullFunctionScope.end)
                        },
        src/extensions/default/JavaScriptRefactoring/WrapSelection.js on lines 189..192

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        "functionsDeclOnly": {
                            "start": current.cm.posFromIndex(loc.functionsDeclOnly.start),
                            "end": current.cm.posFromIndex(loc.functionsDeclOnly.end)
                        }
        src/extensions/default/JavaScriptRefactoring/WrapSelection.js on lines 185..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                } else {
                    var selectionDetails = RefactoringUtils.normalizeText(selectedText, startIndex, endIndex);
                    selectedText = selectionDetails.text;
                    startIndex = selectionDetails.start;
                    endIndex = selectionDetails.end;
        Severity: Minor
        Found in src/extensions/default/JavaScriptRefactoring/WrapSelection.js and 1 other location - About 55 mins to fix
        src/extensions/default/JavaScriptRefactoring/WrapSelection.js on lines 241..246

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (selectedText.length >= 1) {
                    var selectionDetails = RefactoringUtils.normalizeText(selectedText, startIndex, endIndex);
                    selectedText = selectionDetails.text;
                    startIndex = selectionDetails.start;
                    endIndex = selectionDetails.end;
        Severity: Minor
        Found in src/extensions/default/JavaScriptRefactoring/WrapSelection.js and 1 other location - About 55 mins to fix
        src/extensions/default/JavaScriptRefactoring/WrapSelection.js on lines 78..83

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status