adobe/brackets

View on GitHub
src/extensions/default/QuickView/main.js

Summary

Maintainability
F
3 days
Test Coverage

File main.js has 556 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Major
Found in src/extensions/default/QuickView/main.js - About 1 day to fix

    Function colorAndGradientPreviewProvider has 195 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function colorAndGradientPreviewProvider(editor, pos, token, line) {
    
            // Check for gradient. -webkit-gradient() can have parens in parameters
            // nested 2 levels. Other gradients can only nest 1 level.
            var gradientRegEx = /-webkit-gradient\((?:[^\(]*?(?:\((?:[^\(]*?(?:\([^\)]*?\))*?)*?\))*?)*?\)|(?:(?:-moz-|-ms-|-o-|-webkit-|:|\s)((repeating-)?linear-gradient)|(?:-moz-|-ms-|-o-|-webkit-|:|\s)((repeating-)?radial-gradient))(\((?:[^\)]*?(?:\([^\)]*?\))*?)*?\))/gi,
    Severity: Major
    Found in src/extensions/default/QuickView/main.js - About 7 hrs to fix

      Function imagePreviewProvider has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function imagePreviewProvider(editor, pos, token, line) {
              var cm = editor._codeMirror;
      
              // Check for image name
              var urlRegEx = /url\(([^\)]*)\)/gi,
      Severity: Major
      Found in src/extensions/default/QuickView/main.js - About 3 hrs to fix

        Function normalizeGradientExpressionForQuickview has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function normalizeGradientExpressionForQuickview(expression) {
                    if (expression.indexOf("px") > 0) {
                        var paramStart = expression.indexOf("(") + 1,
                            paramEnd = expression.lastIndexOf(")"),
                            parameters = expression.substring(paramStart, paramEnd),
        Severity: Minor
        Found in src/extensions/default/QuickView/main.js - About 1 hr to fix

          Function execColorMatch has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  function execColorMatch(editor, line, pos) {
                      var colorMatch,
                          ignoreNamedColors;
          
                      function hyphenOnMatchBoundary(match, line) {
          Severity: Minor
          Found in src/extensions/default/QuickView/main.js - About 1 hr to fix

            Function showPreview has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function showPreview(editor, popover) {
                    var token, cm;
            
                    // Figure out which editor we are over
                    if (!editor) {
            Severity: Minor
            Found in src/extensions/default/QuickView/main.js - About 1 hr to fix

              Function positionPreview has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function positionPreview(editor, xpos, ypos, ybot) {
                      var previewWidth  = $previewContainer.outerWidth(),
                          top           = ypos - $previewContainer.outerHeight() - POINTER_HEIGHT,
                          left          = xpos - previewWidth / 2,
                          elementRect = {
              Severity: Minor
              Found in src/extensions/default/QuickView/main.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (clip.left > 0) {
                            left += clip.left;
                        } else if (clip.right > 0) {
                            left -= clip.right;
                        }
                Severity: Major
                Found in src/extensions/default/QuickView/main.js and 1 other location - About 1 hr to fix
                src/editor/Editor.js on lines 1919..1923

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status