adobe/brackets

View on GitHub
src/extensions/default/UrlCodeHints/main.js

Summary

Maintainability
D
3 days
Test Coverage

File main.js has 445 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Minor
Found in src/extensions/default/UrlCodeHints/main.js - About 6 hrs to fix

    Function _getUrlList has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        UrlCodeHints.prototype._getUrlList = function (query) {
            var directory,
                doc,
                docDir,
                queryDir = "",
    Severity: Major
    Found in src/extensions/default/UrlCodeHints/main.js - About 3 hrs to fix

      Function getHints has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          UrlCodeHints.prototype.getHints = function (key) {
              var mode = this.editor.getModeForSelection(),
                  cursor = this.editor.getCursorPos(),
                  filter = "",
                  hints = [],
      Severity: Major
      Found in src/extensions/default/UrlCodeHints/main.js - About 3 hrs to fix

        Function insertCssHint has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            UrlCodeHints.prototype.insertCssHint = function (completion) {
                var cursor = this.editor.getCursorPos(),
                    start  = { line: cursor.line, ch: cursor.ch },
                    end    = { line: cursor.line, ch: cursor.ch };
        
        
        Severity: Major
        Found in src/extensions/default/UrlCodeHints/main.js - About 2 hrs to fix

          Function insertHtmlHint has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              UrlCodeHints.prototype.insertHtmlHint = function (completion) {
                  var cursor = this.editor.getCursorPos(),
                      start = {line: -1, ch: -1},
                      end = {line: -1, ch: -1},
                      tagInfo = HTMLUtils.getTagInfo(this.editor, cursor),
          Severity: Minor
          Found in src/extensions/default/UrlCodeHints/main.js - About 1 hr to fix

            Function hasHtmlHints has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                UrlCodeHints.prototype.hasHtmlHints = function (editor, implicitChar) {
                    var tagInfo,
                        query,
                        tokenType;
            
            
            Severity: Minor
            Found in src/extensions/default/UrlCodeHints/main.js - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                                          if (self.cachedHints.deferred &&
                                                  self.cachedHints.deferred.state() === "pending") {
                                              self.cachedHints.deferred.reject();
                                              self.cachedHints.deferred = null;
                                          }
              Severity: Major
              Found in src/extensions/default/UrlCodeHints/main.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if (hints[i].toLowerCase().indexOf(query) === 0) {
                                            foundPrefix = true;
                                            break;
                                        }
                Severity: Major
                Found in src/extensions/default/UrlCodeHints/main.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                              if (currentDeferred && currentDeferred.state() === "pending") {
                                                  currentDeferred.reject();
                                              }
                  Severity: Major
                  Found in src/extensions/default/UrlCodeHints/main.js - About 45 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return deferred;
                    Severity: Major
                    Found in src/extensions/default/UrlCodeHints/main.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return null;
                      Severity: Major
                      Found in src/extensions/default/UrlCodeHints/main.js - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        result = $.map(asyncHints, function (item) {
                                            if (item.toLowerCase().indexOf(lowerCaseFilter) === 0) {
                                                return item;
                                            }
                                        }).sort(sortFunc);
                        Severity: Major
                        Found in src/extensions/default/UrlCodeHints/main.js and 1 other location - About 1 hr to fix
                        src/extensions/default/UrlCodeHints/main.js on lines 481..485

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    result = $.map(hints, function (item) {
                                        if (item.toLowerCase().indexOf(lowerCaseFilter) === 0) {
                                            return item;
                                        }
                                    }).sort(sortFunc);
                        Severity: Major
                        Found in src/extensions/default/UrlCodeHints/main.js and 1 other location - About 1 hr to fix
                        src/extensions/default/UrlCodeHints/main.js on lines 499..503

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status