adobe/brackets

View on GitHub
src/filesystem/impls/appshell/AppshellFileSystem.js

Summary

Maintainability
C
1 day
Test Coverage

File AppshellFileSystem.js has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Minor
Found in src/filesystem/impls/appshell/AppshellFileSystem.js - About 3 hrs to fix

    Function writeFile has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function writeFile(path, data, options, callback) {
            var encoding = options.encoding || "utf8",
                preserveBOM = options.preserveBOM;
    
            function _finishWrite(created) {
    Severity: Minor
    Found in src/filesystem/impls/appshell/AppshellFileSystem.js - About 1 hr to fix

      Function _mapError has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function _mapError(err) {
              if (!err) {
                  return null;
              }
      
      
      Severity: Minor
      Found in src/filesystem/impls/appshell/AppshellFileSystem.js - About 1 hr to fix

        Function showOpenDialog has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function showOpenDialog(allowMultipleSelection, chooseDirectories, title, initialPath, fileTypes, callback) {
        Severity: Minor
        Found in src/filesystem/impls/appshell/AppshellFileSystem.js - About 45 mins to fix

          Function _fileWatcherChange has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function _fileWatcherChange(evt, event, parentDirPath, entryName, statsObj) {
          Severity: Minor
          Found in src/filesystem/impls/appshell/AppshellFileSystem.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var _bracketsPath   = FileUtils.getNativeBracketsDirectoryPath(),
                    _modulePath     = FileUtils.getNativeModuleDirectoryPath(module),
                    _nodePath       = "node/FileWatcherDomain",
                    _domainPath     = [_bracketsPath, _modulePath, _nodePath].join("/"),
                    _nodeDomain     = new NodeDomain("fileWatcher", _domainPath);
            Severity: Major
            Found in src/filesystem/impls/appshell/AppshellFileSystem.js and 1 other location - About 1 hr to fix
            src/LiveDevelopment/MultiBrowserImpl/launchers/Launcher.js on lines 30..34

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                function moveToTrash(path, callback) {
                    appshell.fs.moveToTrash(path, function (err) {
                        callback(_mapError(err));
                    });
                }
            Severity: Minor
            Found in src/filesystem/impls/appshell/AppshellFileSystem.js and 1 other location - About 35 mins to fix
            src/filesystem/impls/appshell/AppshellFileSystem.js on lines 470..474

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                function unlink(path, callback) {
                    appshell.fs.unlink(path, function (err) {
                        callback(_mapError(err));
                    });
                }
            Severity: Minor
            Found in src/filesystem/impls/appshell/AppshellFileSystem.js and 1 other location - About 35 mins to fix
            src/filesystem/impls/appshell/AppshellFileSystem.js on lines 484..488

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    } else {
                        exports.stat(path, function (_err, _stat) {
                            if (_err) {
                                callback(_err);
                            } else {
            Severity: Minor
            Found in src/filesystem/impls/appshell/AppshellFileSystem.js and 1 other location - About 35 mins to fix
            src/languageTools/LanguageClient/NodeToBracketsInterface.js on lines 107..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status