Sign upLogin

adobe/brackets

View on GitHub
Star
src/languageTools/LanguageClient/ProtocolAdapter.js

Summary

Maintainability
D
2 days
Test Coverage

Function _constructParamsAndRelay has 157 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function _constructParamsAndRelay(relay, type, params) {
    var _params = null,
        handler = null;

    //Check for param object format. We won't change anything if the object is preformatted.
Severity: Major
Found in src/languageTools/LanguageClient/ProtocolAdapter.js - About 6 hrs to fix

    File ProtocolAdapter.js has 317 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (c) 2019 - present Adobe. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
    Severity: Minor
    Found in src/languageTools/LanguageClient/ProtocolAdapter.js - About 3 hrs to fix

      Function _constructParamsAndRelay has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function _constructParamsAndRelay(relay, type, params) {
    var _params = null,
        handler = null;

    //Check for param object format. We won't change anything if the object is preformatted.
      Severity: Minor
      Found in src/languageTools/LanguageClient/ProtocolAdapter.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return documentSymbol(relay, _params);
      Severity: Major
      Found in src/languageTools/LanguageClient/ProtocolAdapter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return workspaceSymbol(relay, _params);
        Severity: Major
        Found in src/languageTools/LanguageClient/ProtocolAdapter.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function _callbackFactory(type) {
        switch (type) {
        case protocol.ShowMessageRequest.type:
            return _constructParamsAndRelay.bind(null, handler, ToolingInfo.SERVICE_REQUESTS.SHOW_SELECT_MESSAGE);
        case protocol.RegistrationRequest.type:
          Severity: Major
          Found in src/languageTools/LanguageClient/ProtocolAdapter.js and 1 other location - About 5 hrs to fix
          src/languageTools/LanguageClient/ProtocolAdapter.js on lines 331..342

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 145.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function _callbackFactory(type) {
        switch (type) {
        case protocol.ShowMessageNotification.type:
            return _constructParamsAndRelay.bind(null, handler, ToolingInfo.SERVICE_NOTIFICATIONS.SHOW_MESSAGE);
        case protocol.LogMessageNotification.type:
          Severity: Major
          Found in src/languageTools/LanguageClient/ProtocolAdapter.js and 1 other location - About 5 hrs to fix
          src/languageTools/LanguageClient/ProtocolAdapter.js on lines 358..369

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 145.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status