adobe/brackets

File PreferencesBase.js has 998 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),

Function _addToScopeOrder has 55 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _addToScopeOrder: function (id, scope, promise, addBefore) {
            var shadowScopeOrder = this._defaults._shadowScopeOrder,
                shadowEntry,
                index,
                isPending = false,

Function load has 51 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        load: function () {
            var result = new $.Deferred();
            var path = this.path;
            var createIfMissing = this.createIfMissing;
            var recreateIfInvalid = this.recreateIfInvalid;

Function set has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        set: function (id, value, options, doNotSave) {
            options = options || {};
            var context = this._getContext(options.context),

                // The case where the "default" scope was chosen specifically is special.

Function _tryAddToScopeOrder has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _tryAddToScopeOrder: function (shadowEntry) {
            var shadowScopeOrder = this._defaults._shadowScopeOrder,
                index = _.findIndex(shadowScopeOrder, function (entry) {
                    return entry === shadowEntry;
                }),

Function PreferencesSystem has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function PreferencesSystem(contextBuilder) {
        this.contextBuilder = contextBuilder;

        this._knownPrefs = {};
        this._scopes = {

Function save has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        save: function () {
            if (this._saveInProgress) {
                if (!this._nextSaveDeferred) {
                    this._nextSaveDeferred = new $.Deferred();
                }

Avoid deeply nested control flow statements.

Open

                                    if (err) {
                                        console.log("Cannot move unreadable preferences file " + path + " to trash!!");
                                    } else {
                                        console.log("Brackets has recreated the unreadable preferences file " + path + ". You may refer to the deleted file in trash in case you need it!!");
                                    }

Avoid deeply nested control flow statements.

Open

                            if (pref && pref.type === "object") {
                                result = _.extend({}, pref.initial, result);
                            }

Function set has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

        set: function (data, id, value, context, layerID) {

Function set has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

        set: function (data, id, value, context, layerID) {

Function set has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

        set: function (data, id, value, context, layerID) {

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        off: function (event, preferenceID, handler) {
            if (typeof preferenceID === "function") {
                handler = preferenceID;
                preferenceID = null;
            }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        on: function (event, preferenceID, handler) {
            if (typeof preferenceID === "function") {
                handler = preferenceID;
                preferenceID = null;
            }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        off: function (event, preferenceID, handler) {
            if (typeof preferenceID === "function") {
                handler = preferenceID;
                preferenceID = null;
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                                appshell.fs.moveToTrash(path, function (err) {
                                    if (err) {
                                        console.log("Cannot move unreadable preferences file " + path + " to trash!!");
                                    } else {
                                        console.log("Brackets has recreated the unreadable preferences file " + path + ". You may refer to the deleted file in trash in case you need it!!");

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                                appshell.fs.moveToTrash(path, function (err) {
                                    if (err) {
                                        console.log("Cannot move unparseable preferences file " + path + " to trash!!");
                                    } else {
                                        console.log("Brackets has recreated the Invalid JSON preferences file " + path + ". You may refer to the deleted file in trash in case you need it!!");

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (!_.isEqual(section[id], value)) {
                if (value === undefined) {
                    delete section[id];
                } else {
                    section[id] = _.cloneDeep(value);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (!_.isEqual(section[id], value)) {
                if (value === undefined) {
                    delete section[id];
                } else {
                    section[id] = _.cloneDeep(value);

• Read up
  Read up