Sign upLogin

adobe/brackets

View on GitHub
Star
src/project/FileSyncManager.js

Summary

Maintainability
D
2 days
Test Coverage

Function presentConflicts has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function presentConflicts(title) {

        var allConflicts = editConflicts.concat(deleteConflicts);

        function presentConflict(docInfo, i) {
Severity: Major
Found in src/project/FileSyncManager.js - About 3 hrs to fix

    Function presentConflict has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function presentConflict(docInfo, i) {
            var result = new $.Deferred(),
                promise = result.promise(),
                doc = docInfo.doc,
                fileTime = docInfo.fileTime;
    Severity: Major
    Found in src/project/FileSyncManager.js - About 3 hrs to fix

      Function findExternalChanges has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function findExternalChanges(docs) {

        toReload = [];
        toClose = [];
        editConflicts = [];
      Severity: Minor
      Found in src/project/FileSyncManager.js - About 1 hr to fix

        Function checkDoc has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function checkDoc(doc) {
            var result = new $.Deferred();

            // Check file timestamp / existence
        Severity: Minor
        Found in src/project/FileSyncManager.js - About 1 hr to fix

          Function syncOpenDocuments has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function syncOpenDocuments(title) {

        title = title || Strings.EXT_MODIFIED_TITLE;

        // We can become "re-entrant" if the user leaves & then returns to Brackets before we're
          Severity: Minor
          Found in src/project/FileSyncManager.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                            if (doc.isDirty) {
                                    editConflicts.push({doc: doc, fileTime: fileTime});
                                } else {
                                    toReload.push(doc);
                                }
            Severity: Major
            Found in src/project/FileSyncManager.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                              if (doc.isDirty) {
                                    deleteConflicts.push({doc: doc, fileTime: -1});
                                } else {
                                    toClose.push(doc);
                                }
              Severity: Major
              Found in src/project/FileSyncManager.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            } else {
                toClose = true;
                dialogId = DefaultDialogs.DIALOG_ID_EXT_DELETED;
                message = StringUtils.format(
                    Strings.EXT_DELETED_MESSAGE,
                Severity: Major
                Found in src/project/FileSyncManager.js and 1 other location - About 4 hrs to fix
                src/project/FileSyncManager.js on lines 302..324

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 131.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (i < editConflicts.length) {
                toClose = false;
                dialogId = DefaultDialogs.DIALOG_ID_EXT_CHANGED;
                message = StringUtils.format(
                    Strings.EXT_MODIFIED_MESSAGE,
                Severity: Major
                Found in src/project/FileSyncManager.js and 1 other location - About 4 hrs to fix
                src/project/FileSyncManager.js on lines 324..345

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 131.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status