adobe/brackets

View on GitHub
src/project/ProjectManager.js

Summary

Maintainability
F
3 days
Test Coverage

File ProjectManager.js has 762 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Major
Found in src/project/ProjectManager.js - About 1 day to fix

    Function _loadProject has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function _loadProject(rootPath, isUpdating) {
            var result = new $.Deferred(),
                startLoad = new $.Deferred();
    
            // Some legacy code calls this API with a non-canonical path
    Severity: Major
    Found in src/project/ProjectManager.js - About 3 hrs to fix

      Function _getFallbackProjectPath has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function _getFallbackProjectPath() {
              var fallbackPaths = [],
                  recentProjects = PreferencesManager.getViewState("recentProjects") || [],
                  deferred = new $.Deferred();
      
      
      Severity: Minor
      Found in src/project/ProjectManager.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            FileViewController.openFileAndAddToWorkingSet(projectPrefFullPath, paneId)
                                .done(function () {
                                    Dialogs.showModalDialog(
                                        DefaultDialogs.DIALOG_ID_ERROR,
                                        Strings.ERROR_PREFS_CORRUPT_TITLE,
        Severity: Major
        Found in src/project/ProjectManager.js and 1 other location - About 2 hrs to fix
        src/brackets.js on lines 349..359

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            ActionCreator.prototype.toggleSubdirectories = function (path, openOrClose) {
                this.model.toggleSubdirectories(path, openOrClose).then(_saveTreeState);
            };
        Severity: Minor
        Found in src/project/ProjectManager.js and 1 other location - About 45 mins to fix
        src/project/ProjectManager.js on lines 265..267

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            ActionCreator.prototype.setDirectoryOpen = function (path, open) {
                this.model.setDirectoryOpen(path, open).then(_saveTreeState);
            };
        Severity: Minor
        Found in src/project/ProjectManager.js and 1 other location - About 45 mins to fix
        src/project/ProjectManager.js on lines 368..370

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                case ERR_TYPE_DELETE:
                    title = StringUtils.format(Strings.ERROR_DELETING_FILE_TITLE, titleType);
                    message = StringUtils.format(Strings.ERROR_DELETING_FILE, path, error, entryType);
                    break;
        Severity: Major
        Found in src/project/ProjectManager.js and 3 other locations - About 35 mins to fix
        src/project/ProjectManager.js on lines 618..621
        src/project/ProjectManager.js on lines 626..629
        src/project/ProjectManager.js on lines 630..633

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                case ERR_TYPE_CREATE:
                    title = StringUtils.format(Strings.ERROR_CREATING_FILE_TITLE, titleType);
                    message = StringUtils.format(Strings.ERROR_CREATING_FILE, entryType, path, error);
                    break;
        Severity: Major
        Found in src/project/ProjectManager.js and 3 other locations - About 35 mins to fix
        src/project/ProjectManager.js on lines 626..629
        src/project/ProjectManager.js on lines 630..633
        src/project/ProjectManager.js on lines 634..637

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                case ERR_TYPE_MOVE:
                    title = StringUtils.format(Strings.ERROR_MOVING_FILE_TITLE, titleType);
                    message = StringUtils.format(Strings.ERROR_MOVING_FILE, path, error, entryType);
                    break;
        Severity: Major
        Found in src/project/ProjectManager.js and 3 other locations - About 35 mins to fix
        src/project/ProjectManager.js on lines 618..621
        src/project/ProjectManager.js on lines 626..629
        src/project/ProjectManager.js on lines 634..637

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                case ERR_TYPE_RENAME:
                    title = StringUtils.format(Strings.ERROR_RENAMING_FILE_TITLE, titleType);
                    message = StringUtils.format(Strings.ERROR_RENAMING_FILE, path, error, entryType);
                    break;
        Severity: Major
        Found in src/project/ProjectManager.js and 3 other locations - About 35 mins to fix
        src/project/ProjectManager.js on lines 618..621
        src/project/ProjectManager.js on lines 630..633
        src/project/ProjectManager.js on lines 634..637

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status