adobe/brackets

View on GitHub
src/project/ProjectModel.js

Summary

Maintainability
F
3 days
Test Coverage

File ProjectModel.js has 740 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2014 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Major
Found in src/project/ProjectModel.js - About 1 day to fix

    Function performRename has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        ProjectModel.prototype.performRename = function () {
            var renameInfo = this._selections.rename;
            if (!renameInfo) {
                return;
            }
    Severity: Major
    Found in src/project/ProjectModel.js - About 2 hrs to fix

      Function handleFSEvent has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          ProjectModel.prototype.handleFSEvent = function (entry, added, removed) {
              this._resetCache();
      
              if (!entry) {
                  this.refresh();
      Severity: Minor
      Found in src/project/ProjectModel.js - About 1 hr to fix

        Function setDirectoryOpen has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            ProjectModel.prototype.setDirectoryOpen = function (path, open) {
                var projectRelative = this.makeProjectRelativeIfPossible(path),
                    needsLoading    = !this._viewModel.isPathLoaded(projectRelative),
                    d               = new $.Deferred(),
                    self            = this;
        Severity: Minor
        Found in src/project/ProjectModel.js - About 1 hr to fix

          Function startRename has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              ProjectModel.prototype.startRename = function (path, isMoved) {
                  var d = new $.Deferred();
                  path = _getPathFromFSObject(path);
                  if (!path) {
                      path = this._selections.context;
          Severity: Minor
          Found in src/project/ProjectModel.js - About 1 hr to fix

            Function doCreate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function doCreate(path, isFolder) {
                    var d = new $.Deferred();
                    var filename = FileUtils.getBaseName(path);
            
                    // Check if filename
            Severity: Minor
            Found in src/project/ProjectModel.js - About 1 hr to fix

              Function _getAllFilesCache has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  ProjectModel.prototype._getAllFilesCache = function _getAllFilesCache(sort) {
                      if (!this._allFilesCachePromise) {
                          var deferred = new $.Deferred(),
                              allFiles = [],
                              allFilesVisitor = function (entry) {
              Severity: Minor
              Found in src/project/ProjectModel.js - About 1 hr to fix

                Function getAllFiles has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    ProjectModel.prototype.getAllFiles = function getAllFiles(filter, additionalFiles, sort) {
                        // The filter and includeWorkingSet params are both optional.
                        // Handle the case where filter is omitted but includeWorkingSet is
                        // specified.
                        if (additionalFiles === undefined && typeof (filter) !== "function") {
                Severity: Minor
                Found in src/project/ProjectModel.js - About 1 hr to fix

                  Function setSelected has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      ProjectModel.prototype.setSelected = function (path, doNotOpen) {
                          path = _getPathFromFSObject(path);
                  
                          // Directories are not selectable
                          if (!_pathIsFile(path)) {
                  Severity: Minor
                  Found in src/project/ProjectModel.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (this._selections.selected &&
                                        _.find(removed, { fullPath: this._selections.selected })) {
                                    this.setSelected(null);
                                }
                    Severity: Minor
                    Found in src/project/ProjectModel.js and 1 other location - About 55 mins to fix
                    src/project/ProjectModel.js on lines 1238..1241

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (this._selections.context &&
                                        _.find(removed, { fullPath: this._selections.context })) {
                                    this.setContext(null);
                                }
                    Severity: Minor
                    Found in src/project/ProjectModel.js and 1 other location - About 55 mins to fix
                    src/project/ProjectModel.js on lines 1228..1231

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        ProjectModel.prototype.setScrollerInfo = function (scrollWidth, scrollTop, scrollLeft, offsetTop) {
                            this._viewModel.setSelectionScrollerInfo(scrollWidth, scrollTop, scrollLeft, offsetTop);
                        };
                    Severity: Minor
                    Found in src/project/ProjectModel.js and 1 other location - About 35 mins to fix
                    src/filesystem/FileSystem.js on lines 740..742

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status