Sign upLogin

adobe/brackets

View on GitHub
Star
src/search/FindInFilesUI.js

Summary

Maintainability
D
1 day
Test Coverage

Function _showFindBar has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function _showFindBar(scope, showReplace) {
        FindUtils.notifySearchScopeChanged();
        // If the scope is a file with a custom viewer, then we
        // don't show find in files dialog.
        if (scope && !EditorManager.canOpenPath(scope.fullPath)) {
Severity: Major
Found in src/search/FindInFilesUI.js - About 3 hrs to fix

    File FindInFilesUI.js has 321 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (c) 2014 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
    Severity: Minor
    Found in src/search/FindInFilesUI.js - About 3 hrs to fix

      Function _finishReplaceBatch has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function _finishReplaceBatch(model) {
        var replaceText = model.replaceText;
        if (replaceText === null) {
            return;
        }
      Severity: Major
      Found in src/search/FindInFilesUI.js - About 2 hrs to fix

        Function searchAndShowResults has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function searchAndShowResults(queryInfo, scope, filter, replaceText, candidateFilesPromise) {
        return FindInFiles.doSearchInScope(queryInfo, scope, filter, replaceText, candidateFilesPromise)
            .done(function (zeroFilesToken) {
                // Done searching all files: show results
                if (FindInFiles.searchModel.hasResults()) {
        Severity: Minor
        Found in src/search/FindInFilesUI.js - About 1 hr to fix

          Function searchAndShowResults has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function searchAndShowResults(queryInfo, scope, filter, replaceText, candidateFilesPromise) {
          Severity: Minor
          Found in src/search/FindInFilesUI.js - About 35 mins to fix

            Function searchAndReplaceResults has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function searchAndReplaceResults(queryInfo, scope, filter, replaceText, candidateFilesPromise) {
            Severity: Minor
            Found in src/search/FindInFilesUI.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      _resultsView
            .on("replaceBatch", function () {
                _finishReplaceBatch(model);
            })
            .on("close", function () {
              Severity: Major
              Found in src/search/FindInFilesUI.js and 1 other location - About 1 hr to fix
              src/search/FindInFilesUI.js on lines 466..486

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status