adobe/brackets

View on GitHub
src/search/QuickOpen.js

Summary

Maintainability
D
2 days
Test Coverage

File QuickOpen.js has 496 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
Severity: Minor
Found in src/search/QuickOpen.js - About 7 hrs to fix

    Function showDialog has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        QuickNavigateDialog.prototype.showDialog = function (prefix, initialString) {
            if (this.isOpen) {
                return;
            }
            this.isOpen = true;
    Severity: Minor
    Found in src/search/QuickOpen.js - About 1 hr to fix

      Function _filterCallback has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          QuickNavigateDialog.prototype._filterCallback = function (query) {
              // Re-evaluate which plugin is active each time query string changes
              currentPlugin = null;
      
              // "Go to line" mode is special-cased
      Severity: Minor
      Found in src/search/QuickOpen.js - About 1 hr to fix

        Function QuickOpenPlugin has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function QuickOpenPlugin(name, languageIds, done, search, match, itemFocus, itemSelect, resultsFormatter, matcherOptions, label) {
        Severity: Major
        Found in src/search/QuickOpen.js - About 1 hr to fix

          Function highlightMatch has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function highlightMatch(item, matchClass, rangeFilter) {
                  var label = item.label || item;
                  matchClass = matchClass || "quicksearch-namematch";
          
                  var stringRanges = item.stringRanges;
          Severity: Minor
          Found in src/search/QuickOpen.js - About 1 hr to fix

            Function _handleItemSelect has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                QuickNavigateDialog.prototype._handleItemSelect = function (selectedItem, query) {
            
                    var doClose = true,
                        self = this;
            
            
            Severity: Minor
            Found in src/search/QuickOpen.js - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                      if (query.length <= 1 || !regInfo ||
                              (regInfo[1] && isNaN(regInfo[1])) ||
                              (regInfo[3] && isNaN(regInfo[3]))) {
              
                          return null;
              Severity: Major
              Found in src/search/QuickOpen.js - About 40 mins to fix

                Avoid too many return statements within this function.
                Open

                        return searchFileList(query, this._filenameMatcher);
                Severity: Major
                Found in src/search/QuickOpen.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          DocumentManager.getDocumentForPath(newFilePath)
                              .done(function (newDoc) {
                                  newDoc.on("languageChanged.quickFindDefinition", function () {
                                      var changedLanguageId = LanguageManager.getLanguageForPath(newDoc.file.fullPath).getId();
                                      _setMenuItemStateForLanguage(changedLanguageId);
                  Severity: Major
                  Found in src/search/QuickOpen.js and 1 other location - About 2 hrs to fix
                  src/features/FindReferencesManager.js on lines 167..173

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 77.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (_canHandleTrigger("@", plugins)) {
                              CommandManager.get(Commands.NAVIGATE_GOTO_DEFINITION).setEnabled(true);
                          } else {
                              CommandManager.get(Commands.NAVIGATE_GOTO_DEFINITION).setEnabled(false);
                          }
                  Severity: Major
                  Found in src/search/QuickOpen.js and 1 other location - About 1 hr to fix
                  src/search/QuickOpen.js on lines 807..811

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (_canHandleTrigger("#", plugins)) {
                              CommandManager.get(Commands.NAVIGATE_GOTO_DEFINITION_PROJECT).setEnabled(true);
                          } else {
                              CommandManager.get(Commands.NAVIGATE_GOTO_DEFINITION_PROJECT).setEnabled(false);
                          }
                  Severity: Major
                  Found in src/search/QuickOpen.js and 1 other location - About 1 hr to fix
                  src/search/QuickOpen.js on lines 801..805

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status