Sign upLogin

adobe/brackets

View on GitHub
Star
src/utils/HealthLogger.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function fileClosed has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function fileClosed(file) {
        if (!file) {
            return;
        }
        var language = LanguageManager.getLanguageForPath(file._path),
Severity: Minor
Found in src/utils/HealthLogger.js - About 1 hr to fix

    Function fileOpened has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function fileOpened(filePath, addedToWorkingSet, encoding) {
        if (!shouldLogHealthData()) {
            return;
        }
        var fileExtension = FileUtils.getFileExtension(filePath),
    Severity: Minor
    Found in src/utils/HealthLogger.js - About 1 hr to fix

      Function _sendData has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function _sendData(fileSize) {
            var subType = "";

            if(fileSize/1024 <= 1) {
      Severity: Minor
      Found in src/utils/HealthLogger.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

                if (isHDTracking && !isEventDataAlreadySent && eventName && eventCategory) {
            eventParams =  {
                eventName: eventName,
                eventCategory: eventCategory,
                eventSubCategory: eventSubCategory || "",
        Severity: Major
        Found in src/utils/HealthLogger.js - About 1 hr to fix

          Function sendAnalyticsData has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function sendAnalyticsData(eventName, eventCategory, eventSubCategory, eventType, eventSubType) {
          Severity: Minor
          Found in src/utils/HealthLogger.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            } else if (fileSize <= 100) {
                    subType = "Size_50_100KB";
                } else if (fileSize <= 500) {
                    subType = "Size_100_500KB";
                } else {
            Severity: Minor
            Found in src/utils/HealthLogger.js and 1 other location - About 40 mins to fix
            src/utils/HealthLogger.js on lines 245..251

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if(fileSize <= 2) {
                    subType = "Size_1_2MB";
                } else if(fileSize <= 5) {
                    subType = "Size_2_5MB";
                } else {
            Severity: Minor
            Found in src/utils/HealthLogger.js and 1 other location - About 40 mins to fix
            src/utils/HealthLogger.js on lines 235..241

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status