adobe/brackets

View on GitHub
src/utils/Resizer.js

Summary

Maintainability
D
2 days
Test Coverage

Function makeResizable has 244 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function makeResizable(element, direction, position, minSize, collapsible, forceLeft, createdByWorkspaceManager, usePercentages, _attachToParent) {
        var $resizer            = $('<div class="' + direction + '-resizer"></div>'),
            $element            = $(element),
            $parent             = $element.parent(),
            $resizableElement   = $($element.find(".resizable-content:first")[0]),
Severity: Major
Found in src/utils/Resizer.js - About 1 day to fix

    File Resizer.js has 382 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
     * Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.
     *
     * Permission is hereby granted, free of charge, to any person obtaining a
     * copy of this software and associated documentation files (the "Software"),
    Severity: Minor
    Found in src/utils/Resizer.js - About 5 hrs to fix

      Function makeResizable has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          function makeResizable(element, direction, position, minSize, collapsible, forceLeft, createdByWorkspaceManager, usePercentages, _attachToParent) {
      Severity: Major
      Found in src/utils/Resizer.js - About 1 hr to fix

        Function doRedraw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    function doRedraw() {
                        // only run this if the mouse is down so we don't constantly loop even
                        // after we're done resizing.
                        if (!isResizing) {
                            return;
        Severity: Minor
        Found in src/utils/Resizer.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                              return this; // chainable
          Severity: Major
          Found in src/utils/Resizer.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (!isWindowResizing) {
                        isWindowResizing = true;
            
                        // We don't need any fancy debouncing here - we just need to react before the user can start
                        // resizing any panels at the new window size. So just listen for first mousemove once the
            Severity: Major
            Found in src/utils/Resizer.js and 1 other location - About 1 hr to fix
            src/view/WorkspaceManager.js on lines 133..143

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                function hide(element) {
                    var hideFunc = $(element).data("hide");
                    if (hideFunc) {
                        hideFunc.apply(element);
                    }
            Severity: Major
            Found in src/utils/Resizer.js and 3 other locations - About 45 mins to fix
            src/utils/Resizer.js on lines 75..80
            src/utils/Resizer.js on lines 110..115
            src/utils/Resizer.js on lines 122..127

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                function resyncSizer(element) {
                    var resyncSizerFunc = $(element).data("resyncSizer");
                    if (resyncSizerFunc) {
                        resyncSizerFunc.apply(element);
                    }
            Severity: Major
            Found in src/utils/Resizer.js and 3 other locations - About 45 mins to fix
            src/utils/Resizer.js on lines 75..80
            src/utils/Resizer.js on lines 86..91
            src/utils/Resizer.js on lines 110..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                function show(element) {
                    var showFunc = $(element).data("show");
                    if (showFunc) {
                        showFunc.apply(element);
                    }
            Severity: Major
            Found in src/utils/Resizer.js and 3 other locations - About 45 mins to fix
            src/utils/Resizer.js on lines 86..91
            src/utils/Resizer.js on lines 110..115
            src/utils/Resizer.js on lines 122..127

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                function removeSizable(element) {
                    var removeSizableFunc = $(element).data("removeSizable");
                    if (removeSizableFunc) {
                        removeSizableFunc.apply(element);
                    }
            Severity: Major
            Found in src/utils/Resizer.js and 3 other locations - About 45 mins to fix
            src/utils/Resizer.js on lines 75..80
            src/utils/Resizer.js on lines 86..91
            src/utils/Resizer.js on lines 122..127

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status