afimb/ninoxe

View on GitHub

Showing 32 of 58 total issues

Class TimeTable has 50 methods (exceeds 20 allowed). Consider refactoring.
Open

class Chouette::TimeTable < Chouette::TridentActiveRecord
  # FIXME http://jira.codehaus.org/browse/JRUBY-6358
  self.primary_key = "id"

  acts_as_taggable
Severity: Minor
Found in app/models/chouette/time_table.rb - About 7 hrs to fix

    Class StopArea has 40 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Chouette::StopArea < Chouette::TridentActiveRecord
      # FIXME http://jira.codehaus.org/browse/JRUBY-6358
      self.primary_key = "id"
      include Geokit::Mappable
      has_many :stop_points, :dependent => :destroy
    Severity: Minor
    Found in app/models/chouette/stop_area.rb - About 5 hrs to fix

      File time_table.rb has 365 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class Chouette::TimeTable < Chouette::TridentActiveRecord
        # FIXME http://jira.codehaus.org/browse/JRUBY-6358
        self.primary_key = "id"
      
        acts_as_taggable
      Severity: Minor
      Found in app/models/chouette/time_table.rb - About 4 hrs to fix

        Method merge! has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
        Open

          def merge!(another_tt)
            transaction do
            # if one tt has no period, just merge lists
            if self.periods.empty? || another_tt.periods.empty?
              if !another_tt.periods.empty?
        Severity: Minor
        Found in app/models/chouette/time_table.rb - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Class Route has 23 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class Chouette::Route < Chouette::TridentActiveRecord
          # FIXME http://jira.codehaus.org/browse/JRUBY-6358
          self.primary_key = "id"
        
          attr_accessor :wayback_code
        Severity: Minor
        Found in app/models/chouette/route.rb - About 2 hrs to fix

          File stop_area.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'geokit'
          require 'geo_ruby'
          
          class Chouette::StopArea < Chouette::TridentActiveRecord
            # FIXME http://jira.codehaus.org/browse/JRUBY-6358
          Severity: Minor
          Found in app/models/chouette/stop_area.rb - About 2 hrs to fix

            Method merge! has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def merge!(another_tt)
                transaction do
                # if one tt has no period, just merge lists
                if self.periods.empty? || another_tt.periods.empty?
                  if !another_tt.periods.empty?
            Severity: Minor
            Found in app/models/chouette/time_table.rb - About 1 hr to fix

              Method valid_days has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                def valid_days
                  # Build an array with day of calendar week (1-7, Monday is 1).
                  [].tap do |valid_days|
                    valid_days << 1  if monday
                    valid_days << 2  if tuesday
              Severity: Minor
              Found in app/models/chouette/time_table.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method valid_days has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.valid_days(int_day_types)
                  # Build an array with day of calendar week (1-7, Monday is 1).
                  [].tap do |valid_days|
                    valid_days << 1  if day_by_mask(int_day_types,4)
                    valid_days << 2  if day_by_mask(int_day_types,8)
              Severity: Minor
              Found in app/models/chouette/time_table.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method detail_access_link_matrix has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def detail_access_link_matrix
                   matrix = Array.new
                   hash = Hash.new
                   access_links.each do |link|
                      hash[link.link_key] = link
              Severity: Minor
              Found in app/models/chouette/access_point.rb - About 1 hr to fix

                Method bounding_dates has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                  def bounding_dates
                    bounding_min = self.dates.select{|d| d.in_out}.map(&:date).compact.min
                    bounding_max = self.dates.select{|d| d.in_out}.map(&:date).compact.max
                
                    unless self.periods.empty?
                Severity: Minor
                Found in app/models/chouette/time_table.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method validate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    def validate(record)
                      timeband = record.timeband
                      if timeband
                        first_departure_time = record.first_departure_time.utc.strftime( "%H%M%S%N" )
                        last_departure_time  = record.last_departure_time.utc.strftime( "%H%M%S%N" )
                Severity: Minor
                Found in app/models/chouette/journey_frequency.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method generic_access_link_matrix has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def generic_access_link_matrix
                     matrix = Array.new
                     hash = Hash.new
                     access_links.each do |link|
                        hash[link.link_key] = link
                Severity: Minor
                Found in app/models/chouette/access_point.rb - About 1 hr to fix

                  Method import_csv has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def self.import_csv
                      csv_file = Rails.root + "chouette_pt_links.csv"
                      if File.exists?( csv_file)
                        csv = CSV::Reader.parse(File.read(csv_file))
                  
                  
                  Severity: Minor
                  Found in app/models/chouette/pt_link.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method control_route_sections_by_stop_areas has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def control_route_sections_by_stop_areas(stop_area_ids)
                      journey_pattern_section_all
                      i = 0
                      to_control = false
                      stop_area_ids.each_cons(2) do |a|
                  Severity: Minor
                  Found in app/models/chouette/journey_pattern.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method prepare_auto_columns has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def prepare_auto_columns
                        # logger.info 'calling before_validation'
                        # logger.info 'start before_validation : '+self.objectid.to_s
                        if self.objectid.nil? || self.objectid.blank?
                          # if empty, generate a pending objectid which will be completed after creation
                  Severity: Minor
                  Found in app/models/chouette/trident_active_record.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method matrix has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def self.matrix(vehicle_journeys)
                        hash = {}
                        vehicle_journeys.each do |vj|
                          vj.journey_frequencies.each do |jf|
                            next if jf.scheduled_headway_interval.hour == 0 && jf.scheduled_headway_interval.min == 0
                  Severity: Minor
                  Found in app/models/chouette/vehicle_journey_frequency.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method optimize_periods has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def optimize_periods
                      periods = self.clone_periods
                      optimized = []
                      i=0
                      while i < periods.length
                  Severity: Minor
                  Found in app/models/chouette/time_table.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method new has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def self.new(text_code, numerical_code = nil)
                      if text_code and numerical_code
                        super
                      elsif self === text_code 
                        text_code
                  Severity: Minor
                  Found in app/models/chouette/connection_link_type.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method periods_min_date has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def periods_min_date
                      return nil if self.periods.empty?
                  
                      min_start = self.periods.map(&:period_start).compact.min
                      max_end = self.periods.map(&:period_end).compact.max
                  Severity: Minor
                  Found in app/models/chouette/time_table.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language