Sign upLogin

agilecreativity/ebook_renamer

View on GitHub
Star

Showing 4 of 4 total issues

Method rename_if_not_the_same has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def rename_if_not_the_same(input_file, output_file, options = {})
      index  = options[:index]
      total  = options[:total]
      commit = options[:commit]
      if input_file != output_file
Severity: Minor
Found in lib/ebook_renamer/cli.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compare_and_rename has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def compare_and_rename(input_file, meta_hash, options, index, total)
Severity: Minor
Found in lib/ebook_renamer/cli.rb - About 35 mins to fix

    Method formatted_name has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def formatted_name(meta_hash = {}, fields = {})
    if hash.nil? || fields.nil?
      fail ArgumentError.new("Argument must not be nil")
    end
    # Let's not continue if we have no title metadata
    Severity: Minor
    Found in lib/ebook_renamer/ebook_renamer.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def execute(options = {})
      input_files = CodeLister.files(options)
      if input_files.empty?
        puts "No file found for your option: #{options}"
        return
    Severity: Minor
    Found in lib/ebook_renamer/cli.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language