Sign upLogin

ahmadnassri/har

View on GitHub
Star
lib/log.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function Log has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Log = function (options) {
  var opts = options || {}

  // internal properties
  Object.defineProperties(this, {
Severity: Major
Found in lib/log.js - About 2 hrs to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      Object.defineProperty(this, 'entries', {
    enumerable: true,

    get: function () {
      return this._entries
    Severity: Major
    Found in lib/log.js and 7 other locations - About 2 hrs to fix
    lib/log.js on lines 42..53
    lib/post-data.js on lines 33..44
    lib/request.js on lines 118..129
    lib/request.js on lines 131..142
    lib/request.js on lines 144..155
    lib/response.js on lines 110..121
    lib/response.js on lines 123..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      Object.defineProperty(this, 'pages', {
    enumerable: true,

    get: function () {
      return this._pages
    Severity: Major
    Found in lib/log.js and 7 other locations - About 2 hrs to fix
    lib/log.js on lines 55..66
    lib/post-data.js on lines 33..44
    lib/request.js on lines 118..129
    lib/request.js on lines 131..142
    lib/request.js on lines 144..155
    lib/response.js on lines 110..121
    lib/response.js on lines 123..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status