aidengleave/acebook-desk-warriors

View on GitHub

Showing 3 of 3 total issues

Method verbose_timestamp has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def verbose_timestamp(datetime)
    elapsed_time = Time.now.to_i - datetime.to_i
    case
    when elapsed_time < 60
      return "Just now"
Severity: Minor
Found in app/models/post.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method can_edit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def can_edit(post_id, current_user_id)
    @post = Post.find(post_id)
    posted_at = @post.created_at
    editable = (Time.now - posted_at) > 600 ? false : true
    editable ? @post.user_id == current_user_id ? true : false : false
Severity: Minor
Found in app/models/post.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return message
Severity: Major
Found in app/models/post.rb - About 30 mins to fix
    Severity
    Category
    Status
    Source
    Language