Sign upLogin

airbnb/caravel

View on GitHub
Star

Showing 2,441 of 6,157 total issues

Consider simplifying this complex logical expression.
Open

    if (
      !fetchingThumbnail &&
      dashboard.id &&
      (thumbnailUrl === undefined || thumbnailUrl === null) &&
      isFeatureEnabled(FeatureFlag.Thumbnails)
Severity: Major
Found in superset-frontend/src/features/dashboards/DashboardCard.tsx - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

          if (
        action.payload.masked_encrypted_extra &&
        action.payload.configuration_method === ConfigurationMethod.DynamicForm
      ) {
        // "extra" payload from the api is a string
    Severity: Major
    Found in superset-frontend/src/features/databases/DatabaseModal/index.tsx - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

          if (
      isEditMode &&
      (!currentLayer?.id ||
        (layer && layer.id !== currentLayer.id) ||
        (isHidden && show))
      Severity: Major
      Found in superset-frontend/src/features/annotationLayers/AnnotationLayerModal.tsx - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

            if (onlyApply) {
      onSubmit(onSubmitProps);
      onHide();
      addSuccessToast(t('Dashboard properties updated'));
    } else {
        Severity: Major
        Found in superset-frontend/src/dashboard/components/PropertiesModal/index.tsx - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

                if (
        chart?.queriesResponse?.[0]?.rejected_filters !==
          prevChart?.queriesResponse?.[0]?.rejected_filters ||
        chart?.queriesResponse?.[0]?.applied_filters !==
          prevChart?.queriesResponse?.[0]?.applied_filters ||
          Severity: Major
          Found in superset-frontend/src/dashboard/components/FiltersBadge/index.tsx - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                if (
      (this.state.didVerify || this.state.error) &&
      (prevProps.endpoint !== endpoint ||
        prevProps.host !== host ||
        prevProps.postPayload !== postPayload ||
            Severity: Major
            Found in superset-frontend/packages/superset-ui-demo/storybook/shared/components/VerifyCORS.tsx - About 40 mins to fix

              Function dateFormat has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  col,
    formatString,
    utcOutput = false,
    mthNames = mthNamesEn,
    dayNames = dayNamesEn,
              Severity: Minor
              Found in superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.js - About 35 mins to fix

                Function jsFunctionControl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  label,
  description,
  extraDescr = null,
  height = 100,
  defaultText = '',
                Severity: Minor
                Found in superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.jsx - About 35 mins to fix

                  Function get_runs has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def get_runs(
                  Severity: Minor
                  Found in scripts/cancel_github_workflows.py - About 35 mins to fix

                    Function submit_explore_json_job has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def submit_explore_json_job(
                    Severity: Minor
                    Found in superset/async_events/async_query_manager.py - About 35 mins to fix

                      Function cancel_github_workflows has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def cancel_github_workflows(
                      Severity: Minor
                      Found in scripts/cancel_github_workflows.py - About 35 mins to fix

                        Function result_pmc has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        def result_pmc(
                        Severity: Minor
                        Found in RELEASING/generate_email.py - About 35 mins to fix

                          Function add_tag_object_if_not_tagged has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def add_tag_object_if_not_tagged(
                          Severity: Minor
                          Found in superset/tags/models.py - About 35 mins to fix

                            Function print_processed_batch has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            def print_processed_batch(
                            Severity: Minor
                            Found in superset/migrations/shared/catalogs.py - About 35 mins to fix

                              Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      def __init__(  # pylint: disable=super-init-not-called
                              Severity: Minor
                              Found in superset/stats_logger.py - About 35 mins to fix

                                Function update_schema_catalog_perms has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                def update_schema_catalog_perms(
                                Severity: Minor
                                Found in superset/migrations/shared/catalogs.py - About 35 mins to fix

                                  Function get_viz has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  def get_viz(
                                  Severity: Minor
                                  Found in superset/views/utils.py - About 35 mins to fix

                                    Function build_extra_filters has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                    def build_extra_filters(  # pylint: disable=too-many-locals,too-many-nested-blocks
                                    Severity: Minor
                                    Found in superset/views/utils.py - About 35 mins to fix

                                      Function __call__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          def __call__(
                                      Severity: Minor
                                      Found in superset/utils/log.py - About 35 mins to fix

                                        Function get_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                            def get_data(
                                        Severity: Minor
                                        Found in superset/extensions/metadb.py - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language