Sign upLogin

airbnb/caravel

View on GitHub
Star

Showing 3,672 of 6,072 total issues

Identical blocks of code found in 4 locations. Consider refactoring.
Open

class Dashboard(Base):
    __tablename__ = "dashboards"
    id = sa.Column(sa.Integer, primary_key=True)
    json_metadata = sa.Column(sa.Text)
Severity: Major
Found in superset/migrations/versions/2021-08-31_11-37_021b81fe4fbb_add_type_to_native_filter_configuration.py and 3 other locations - About 1 hr to fix
superset/migrations/versions/2022-11-28_17-51_4ce1d9b25135_remove_filter_bar_orientation.py on lines 39..42
superset/migrations/versions/2023-02-28_14-46_c0a3ea245b61_remove_show_native_filters.py on lines 39..43
superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py on lines 44..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

class Dashboard(Base):
    __tablename__ = "dashboards"

    id = sa.Column(sa.Integer, primary_key=True)
    json_metadata = sa.Column(sa.Text)
Severity: Major
Found in superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py and 3 other locations - About 1 hr to fix
superset/migrations/versions/2021-08-31_11-37_021b81fe4fbb_add_type_to_native_filter_configuration.py on lines 43..46
superset/migrations/versions/2022-11-28_17-51_4ce1d9b25135_remove_filter_bar_orientation.py on lines 39..42
superset/migrations/versions/2023-02-28_14-46_c0a3ea245b61_remove_show_native_filters.py on lines 39..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

class Dashboard(Base):
    __tablename__ = "dashboards"
    id = sa.Column(sa.Integer, primary_key=True)
    json_metadata = sa.Column(sa.Text)
Severity: Major
Found in superset/migrations/versions/2022-11-28_17-51_4ce1d9b25135_remove_filter_bar_orientation.py and 3 other locations - About 1 hr to fix
superset/migrations/versions/2021-08-31_11-37_021b81fe4fbb_add_type_to_native_filter_configuration.py on lines 43..46
superset/migrations/versions/2023-02-28_14-46_c0a3ea245b61_remove_show_native_filters.py on lines 39..43
superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py on lines 44..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    with op.batch_alter_table("table_columns") as batch_op:
        batch_op.alter_column(
            "column_name", existing_type=String(255), nullable=True, type_=String(256)
Severity: Major
Found in superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py and 3 other locations - About 1 hr to fix
superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py on lines 84..86
superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py on lines 88..90
superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py on lines 120..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    with op.batch_alter_table("sql_metrics") as batch_op:
        batch_op.alter_column(
            "metric_name", existing_type=String(255), nullable=True, type_=String(512)
Severity: Major
Found in superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py and 3 other locations - About 1 hr to fix
superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py on lines 84..86
superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py on lines 112..114
superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py on lines 88..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    with op.batch_alter_table("sql_metrics") as batch_op:
        batch_op.alter_column(
            "metric_name", existing_type=String(512), nullable=False, type_=String(255)
Severity: Major
Found in superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py and 3 other locations - About 1 hr to fix
superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py on lines 84..86
superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py on lines 112..114
superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py on lines 120..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    with op.batch_alter_table("table_columns") as batch_op:
        batch_op.alter_column(
            "column_name", existing_type=String(256), nullable=False, type_=String(255)
Severity: Major
Found in superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py and 3 other locations - About 1 hr to fix
superset/migrations/versions/2018-07-20_15-31_7f2635b51f5d_update_base_columns.py on lines 112..114
superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py on lines 88..90
superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py on lines 120..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

class Dashboard(Base):
    __tablename__ = "dashboards"

    id = sa.Column(sa.Integer, primary_key=True)
    json_metadata = sa.Column(sa.Text)
Severity: Major
Found in superset/migrations/versions/2023-02-28_14-46_c0a3ea245b61_remove_show_native_filters.py and 3 other locations - About 1 hr to fix
superset/migrations/versions/2021-08-31_11-37_021b81fe4fbb_add_type_to_native_filter_configuration.py on lines 43..46
superset/migrations/versions/2022-11-28_17-51_4ce1d9b25135_remove_filter_bar_orientation.py on lines 39..42
superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py on lines 44..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('should render a Toast for each toast object', () => {
  const { getAllByRole } = setup();
  expect(getAllByRole('alert')).toHaveLength(props.toasts.length);
});
Severity: Major
Found in superset-frontend/src/components/MessageToasts/ToastPresenter.test.jsx and 1 other location - About 1 hr to fix
superset-frontend/src/components/MessageToasts/Toast.test.jsx on lines 35..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('should render a WithPopoverMenu', () => {
  // don't count child DragDroppables
  const { getByTestId } = setup({ component: rowWithoutChildren });
  expect(getByTestId('mock-with-popover-menu')).toBeInTheDocument();
});
Severity: Major
Found in superset-frontend/src/dashboard/components/gridComponents/Row.test.jsx and 1 other location - About 1 hr to fix
superset-frontend/src/dashboard/components/gridComponents/Column.test.jsx on lines 120..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('should render a WithPopoverMenu', () => {
  // don't count child DragDroppables
  const { getByTestId } = setup({ component: columnWithoutChildren });
  expect(getByTestId('mock-with-popover-menu')).toBeInTheDocument();
});
Severity: Major
Found in superset-frontend/src/dashboard/components/gridComponents/Column.test.jsx and 1 other location - About 1 hr to fix
superset-frontend/src/dashboard/components/gridComponents/Row.test.jsx on lines 122..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('should render toastText within the div', () => {
  const { getByTestId } = setup();
  expect(getByTestId('toast-container')).toHaveTextContent(props.toast.text);
});
Severity: Major
Found in superset-frontend/src/components/MessageToasts/Toast.test.jsx and 1 other location - About 1 hr to fix
superset-frontend/src/components/MessageToasts/ToastPresenter.test.jsx on lines 38..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should toggle edit mode', () => {
    expect(
      dashboardStateReducer(
        { editMode: false },
        { type: SET_EDIT_MODE, editMode: true },
Severity: Major
Found in superset-frontend/src/dashboard/reducers/dashboardState.test.js and 1 other location - About 1 hr to fix
superset-frontend/src/dashboard/reducers/dashboardState.test.js on lines 58..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should toggle fav star', () => {
    expect(
      dashboardStateReducer(
        { isStarred: false },
        { type: TOGGLE_FAVE_STAR, isStarred: true },
Severity: Major
Found in superset-frontend/src/dashboard/reducers/dashboardState.test.js and 1 other location - About 1 hr to fix
superset-frontend/src/dashboard/reducers/dashboardState.test.js on lines 67..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 11 locations. Consider refactoring.
Open

afterEach(() => {
  fetchMock.reset();
  act(() => {
    store.dispatch(api.util.resetApiState());
  });
Severity: Major
Found in superset-frontend/src/hooks/apiResources/databaseFunctions.test.ts and 10 other locations - About 1 hr to fix
superset-frontend/src/SqlLab/components/AceEditorWrapper/useAnnotations.test.ts on lines 52..57
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts on lines 96..101
superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx on lines 193..198
superset-frontend/src/hooks/apiResources/queries.test.ts on lines 68..73
superset-frontend/src/hooks/apiResources/queryValidations.test.ts on lines 46..51
superset-frontend/src/hooks/apiResources/schemas.test.ts on lines 56..61
superset-frontend/src/hooks/apiResources/sqlEditorTabs.test.ts on lines 48..53
superset-frontend/src/hooks/apiResources/sqlLab.test.ts on lines 52..57
superset-frontend/src/hooks/apiResources/tables.test.ts on lines 74..79
superset-frontend/src/pages/SqlLab/SqlLab.test.tsx on lines 58..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 11 locations. Consider refactoring.
Open

  afterEach(() => {
    fetchMock.reset();
    act(() => {
      store.dispatch(api.util.resetApiState());
    });
Severity: Major
Found in superset-frontend/src/hooks/apiResources/tables.test.ts and 10 other locations - About 1 hr to fix
superset-frontend/src/SqlLab/components/AceEditorWrapper/useAnnotations.test.ts on lines 52..57
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts on lines 96..101
superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx on lines 193..198
superset-frontend/src/hooks/apiResources/databaseFunctions.test.ts on lines 36..41
superset-frontend/src/hooks/apiResources/queries.test.ts on lines 68..73
superset-frontend/src/hooks/apiResources/queryValidations.test.ts on lines 46..51
superset-frontend/src/hooks/apiResources/schemas.test.ts on lines 56..61
superset-frontend/src/hooks/apiResources/sqlEditorTabs.test.ts on lines 48..53
superset-frontend/src/hooks/apiResources/sqlLab.test.ts on lines 52..57
superset-frontend/src/pages/SqlLab/SqlLab.test.tsx on lines 58..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 11 locations. Consider refactoring.
Open

afterEach(() => {
  fetchMock.reset();
  act(() => {
    store.dispatch(api.util.resetApiState());
  });
Severity: Major
Found in superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx and 10 other locations - About 1 hr to fix
superset-frontend/src/SqlLab/components/AceEditorWrapper/useAnnotations.test.ts on lines 52..57
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts on lines 96..101
superset-frontend/src/hooks/apiResources/databaseFunctions.test.ts on lines 36..41
superset-frontend/src/hooks/apiResources/queries.test.ts on lines 68..73
superset-frontend/src/hooks/apiResources/queryValidations.test.ts on lines 46..51
superset-frontend/src/hooks/apiResources/schemas.test.ts on lines 56..61
superset-frontend/src/hooks/apiResources/sqlEditorTabs.test.ts on lines 48..53
superset-frontend/src/hooks/apiResources/sqlLab.test.ts on lines 52..57
superset-frontend/src/hooks/apiResources/tables.test.ts on lines 74..79
superset-frontend/src/pages/SqlLab/SqlLab.test.tsx on lines 58..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 11 locations. Consider refactoring.
Open

afterEach(() => {
  fetchMock.reset();
  act(() => {
    store.dispatch(api.util.resetApiState());
  });
Severity: Major
Found in superset-frontend/src/hooks/apiResources/queries.test.ts and 10 other locations - About 1 hr to fix
superset-frontend/src/SqlLab/components/AceEditorWrapper/useAnnotations.test.ts on lines 52..57
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts on lines 96..101
superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx on lines 193..198
superset-frontend/src/hooks/apiResources/databaseFunctions.test.ts on lines 36..41
superset-frontend/src/hooks/apiResources/queryValidations.test.ts on lines 46..51
superset-frontend/src/hooks/apiResources/schemas.test.ts on lines 56..61
superset-frontend/src/hooks/apiResources/sqlEditorTabs.test.ts on lines 48..53
superset-frontend/src/hooks/apiResources/sqlLab.test.ts on lines 52..57
superset-frontend/src/hooks/apiResources/tables.test.ts on lines 74..79
superset-frontend/src/pages/SqlLab/SqlLab.test.tsx on lines 58..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 11 locations. Consider refactoring.
Open

afterEach(() => {
  fetchMock.reset();
  act(() => {
    store.dispatch(api.util.resetApiState());
  });
Severity: Major
Found in superset-frontend/src/hooks/apiResources/sqlLab.test.ts and 10 other locations - About 1 hr to fix
superset-frontend/src/SqlLab/components/AceEditorWrapper/useAnnotations.test.ts on lines 52..57
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts on lines 96..101
superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx on lines 193..198
superset-frontend/src/hooks/apiResources/databaseFunctions.test.ts on lines 36..41
superset-frontend/src/hooks/apiResources/queries.test.ts on lines 68..73
superset-frontend/src/hooks/apiResources/queryValidations.test.ts on lines 46..51
superset-frontend/src/hooks/apiResources/schemas.test.ts on lines 56..61
superset-frontend/src/hooks/apiResources/sqlEditorTabs.test.ts on lines 48..53
superset-frontend/src/hooks/apiResources/tables.test.ts on lines 74..79
superset-frontend/src/pages/SqlLab/SqlLab.test.tsx on lines 58..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 11 locations. Consider refactoring.
Open

  afterEach(() => {
    fetchMock.reset();
    act(() => {
      store.dispatch(api.util.resetApiState());
    });
Severity: Major
Found in superset-frontend/src/hooks/apiResources/schemas.test.ts and 10 other locations - About 1 hr to fix
superset-frontend/src/SqlLab/components/AceEditorWrapper/useAnnotations.test.ts on lines 52..57
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts on lines 96..101
superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx on lines 193..198
superset-frontend/src/hooks/apiResources/databaseFunctions.test.ts on lines 36..41
superset-frontend/src/hooks/apiResources/queries.test.ts on lines 68..73
superset-frontend/src/hooks/apiResources/queryValidations.test.ts on lines 46..51
superset-frontend/src/hooks/apiResources/sqlEditorTabs.test.ts on lines 48..53
superset-frontend/src/hooks/apiResources/sqlLab.test.ts on lines 52..57
superset-frontend/src/hooks/apiResources/tables.test.ts on lines 74..79
superset-frontend/src/pages/SqlLab/SqlLab.test.tsx on lines 58..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language