Sign upLogin

airbnb/caravel

View on GitHub
Star

Showing 3,672 of 6,072 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  registerLoader(key: string, loader: () => W) {
    super.registerLoader(key, loader);
    // If there is no default, set as default
    if (this.setFirstItemAsDefault && !this.defaultKey) {
      this.defaultKey = key;
Severity: Major
Found in superset-frontend/packages/superset-ui-core/src/models/RegistryWithDefaultKey.ts and 1 other location - About 1 hr to fix
superset-frontend/packages/superset-ui-core/src/models/RegistryWithDefaultKey.ts on lines 59..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    fakeApiResult.result.map(err => ({
      type: 'error',
      row: (err.line_number || 0) - 1,
      column: (err.start_column || 0) - 1,
      text: err.message,
Severity: Major
Found in superset-frontend/src/SqlLab/components/AceEditorWrapper/useAnnotations.test.ts and 1 other location - About 1 hr to fix
superset-frontend/src/SqlLab/components/AceEditorWrapper/useAnnotations.ts on lines 61..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  await renderModal({
    column: { column_name: 'name' },
    drillByConfig: {
      filters: [{ col: 'gender', op: '==', val: 'boy' }],
      groupbyFieldName: 'groupby',
Severity: Major
Found in superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx and 1 other location - About 1 hr to fix
superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx on lines 157..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  return (
    <ErrorAlert
      title={t('Timeout error')}
      subtitle={subtitle}
      level={level}
Severity: Major
Found in superset-frontend/src/components/ErrorMessage/TimeoutErrorMessage.tsx and 1 other location - About 1 hr to fix
superset-frontend/src/components/ErrorMessage/ParameterErrorMessage.tsx on lines 114..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    case NAV_KEYS.tab && e.shiftKey: {
      const { selectedKey, openKey } = getNavigationKeys(
        keys,
        keysMap,
        currentKeyIndex,
Severity: Major
Found in superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx and 1 other location - About 1 hr to fix
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 399..409

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const { dataMask, activeTabs } = useSelector((state: RootState) => ({
    dataMask: state.dataMask,
    activeTabs: state.dashboardState.activeTabs,
  }));
Severity: Major
Found in superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx and 1 other location - About 1 hr to fix
superset-frontend/src/dashboard/components/URLShortLinkButton/index.tsx on lines 45..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const node = svg
    .append('g')
    .selectAll('.node')
    .data(nodes)
    .enter()
Severity: Minor
Found in superset-frontend/plugins/legacy-plugin-chart-sankey/src/Sankey.js and 1 other location - About 55 mins to fix
superset-frontend/plugins/legacy-plugin-chart-sankey/src/Sankey.js on lines 155..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  ${({ theme }) => css`
    &.dashboard-markdown {
      overflow: hidden;

      h4,
Severity: Minor
Found in superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx and 1 other location - About 55 mins to fix
superset-frontend/plugins/legacy-plugin-chart-horizon/src/HorizonChart.jsx on lines 61..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  ${({ theme }) => `
    .superset-legacy-chart-horizon {
      overflow: auto;
      position: relative;
    }
Severity: Minor
Found in superset-frontend/plugins/legacy-plugin-chart-horizon/src/HorizonChart.jsx and 1 other location - About 55 mins to fix
superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx on lines 88..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const link = svg
    .append('g')
    .selectAll('.link')
    .data(links)
    .enter()
Severity: Minor
Found in superset-frontend/plugins/legacy-plugin-chart-sankey/src/Sankey.js and 1 other location - About 55 mins to fix
superset-frontend/plugins/legacy-plugin-chart-sankey/src/Sankey.js on lines 197..204

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      cy.get('@drillByModal')
        .find('.ant-breadcrumb')
        .should('be.visible')
        .and('contain', 'gender (boy)')
        .and('contain', '/')
Severity: Major
Found in superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 127..132
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 266..271
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 340..345
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 633..638

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

test('get permalink key from path params', () => {
  setupLocation(`${EXPLORE_BASE_URL}p/kpOqweaMY9R/`);
  expect(getParsedExploreURLParams().toString()).toEqual(
    'permalink_key=kpOqweaMY9R',
  );
Severity: Major
Found in superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 29..36
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 38..41
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 43..50
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 59..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      cy.get('@drillByModal')
        .find('[data-test="drill-by-chart"]')
        .should('be.visible')
        .and('not.contain', 'name')
        .and('contain', 'state')
Severity: Major
Found in superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 127..132
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 266..271
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 411..416
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 633..638

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

test('get slice_id from form_data search param - url on Chart List', () => {
  setupLocation(`${EXPLORE_BASE_URL}?form_data=%7B%22slice_id%22%3A%2056%7D`);
  expect(getParsedExploreURLParams().toString()).toEqual('slice_id=56');
});
Severity: Major
Found in superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 29..36
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 43..50
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 52..57
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 59..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

test('get dataset id from path params', () => {
  setupLocation(`${EXPLORE_BASE_URL}table/42/`);
  expect(getParsedExploreURLParams().toString()).toEqual('datasource_id=42');
});
Severity: Major
Found in superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 29..36
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 38..41
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 43..50
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 52..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

test('get datasource and viz type from form_data search param - url when creating new chart', () => {
  setupLocation(
    `${EXPLORE_BASE_URL}?form_data=%7B%22viz_type%22%3A%22big_number%22%2C%22datasource%22%3A%222__table%22%7D`,
  );
  expect(getParsedExploreURLParams().toString()).toEqual(
Severity: Major
Found in superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 29..36
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 38..41
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 52..57
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 59..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      cy.get('@drillByModal')
        .find('.ant-breadcrumb')
        .should('be.visible')
        .and('contain', 'gender (boy)')
        .and('contain', '/')
Severity: Major
Found in superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 127..132
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 340..345
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 411..416
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 633..638

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    cy.get('@drillByModal')
      .find('.ant-breadcrumb')
      .should('be.visible')
      .and('contain', 'gender (boy)')
      .and('contain', '/')
Severity: Major
Found in superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 266..271
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 340..345
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 411..416
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 633..638

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        cy.get('@drillByModal')
          .find('.ant-breadcrumb')
          .should('be.visible')
          .and('contain', 'gender (boy)')
          .and('contain', '/')
Severity: Major
Found in superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 127..132
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 266..271
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 340..345
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts on lines 411..416

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

test('get form_data_key and slice_id from search params - url when moving from dashboard to explore', () => {
  setupLocation(
    `${EXPLORE_BASE_URL}?form_data_key=yrLXmyE9fmhQ11lM1KgaD1PoPSBpuLZIJfqdyIdw9GoBwhPFRZHeIgeFiNZljbpd&slice_id=56`,
  );
  expect(getParsedExploreURLParams().toString()).toEqual(
Severity: Major
Found in superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts and 4 other locations - About 55 mins to fix
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 38..41
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 43..50
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 52..57
superset-frontend/src/explore/exploreUtils/getParsedExploreURLParams.test.ts on lines 59..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language