Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/components/Chart/chartAction.js

Summary

Maintainability
D
2 days
Test Coverage

File chartAction.js has 534 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Major
Found in superset-frontend/src/components/Chart/chartAction.js - About 1 day to fix

    Function exploreJSON has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function exploreJSON(
  formData,
  force = false,
  timeout,
  key,
    Severity: Major
    Found in superset-frontend/src/components/Chart/chartAction.js - About 4 hrs to fix

      Function v1ChartDataRequest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const v1ChartDataRequest = async (
  formData,
  resultFormat,
  resultType,
  force,
      Severity: Minor
      Found in superset-frontend/src/components/Chart/chartAction.js - About 1 hr to fix

        Function exploreJSON has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          formData,
  force = false,
  timeout,
  key,
  dashboardId,
        Severity: Minor
        Found in superset-frontend/src/components/Chart/chartAction.js - About 45 mins to fix

          Function postChartFormData has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            formData,
  force = false,
  timeout,
  key,
  dashboardId,
          Severity: Minor
          Found in superset-frontend/src/components/Chart/chartAction.js - About 45 mins to fix

            Function handleChartDataResponse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            export function handleChartDataResponse(response, json, useLegacyApi) {
  if (isFeatureEnabled(FeatureFlag.GlobalAsyncQueries)) {
    // deal with getChartDataRequest transforming the response data
    const result = 'result' in json ? json.result : json;
    switch (response.status) {
            Severity: Minor
            Found in superset-frontend/src/components/Chart/chartAction.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status