superset-frontend/src/dashboard/actions/dashboardState.js
File dashboardState.js
has 633 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
Function saveDashboardRequest
has 232 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export function saveDashboardRequest(data, id, saveType) {
return (dispatch, getState) => {
dispatch({ type: UPDATE_COMPONENTS_PARENTS_LIST });
dispatch(saveDashboardStarted());
Function updateDashboardLabelsColor
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
Open
export const updateDashboardLabelsColor = () => async (dispatch, getState) => {
const {
dashboardInfo: { id, metadata },
} = getState();
const categoricalSchemes = getCategoricalSchemeRegistry();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function updateDashboardLabelsColor
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export const updateDashboardLabelsColor = () => async (dispatch, getState) => {
const {
dashboardInfo: { id, metadata },
} = getState();
const categoricalSchemes = getCategoricalSchemeRegistry();
Function onUpdateSuccess
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
const onUpdateSuccess = response => {
const updatedDashboard = response.json.result;
const lastModifiedTime = response.json.last_modified_time;
// syncing with the backend transformations of the metadata
if (updatedDashboard.json_metadata) {
Function addSliceToDashboard
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export function addSliceToDashboard(id) {
return (dispatch, getState) => {
const { sliceEntities } = getState();
const selectedSlice = sliceEntities.slices[id];
if (!selectedSlice) {
Function savePublished
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export function savePublished(id, isPublished) {
return function savePublishedThunk(dispatch) {
return SupersetClient.put({
endpoint: `/api/v1/dashboard/${id}`,
headers: { 'Content-Type': 'application/json' },