Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/dashboard/reducers/dashboardLayout.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function CREATE_TOP_LEVEL_TABS has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  [CREATE_TOP_LEVEL_TABS](state, action) {
    const {
      payload: { dropResult },
    } = action;
    const { source, dragging } = dropResult;
Severity: Minor
Found in superset-frontend/src/dashboard/reducers/dashboardLayout.js - About 1 hr to fix

    Function MOVE_COMPONENT has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      [MOVE_COMPONENT](state, action) {
    const {
      payload: { dropResult },
    } = action;
    const { source, destination, dragging, position } = dropResult;
    Severity: Minor
    Found in superset-frontend/src/dashboard/reducers/dashboardLayout.js - About 1 hr to fix

      Function recursivelyDeleteChildren has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export function recursivelyDeleteChildren(
  componentId,
  componentParentId,
  nextComponents,
) {
      Severity: Minor
      Found in superset-frontend/src/dashboard/reducers/dashboardLayout.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function MOVE_COMPONENT has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        [MOVE_COMPONENT](state, action) {
    const {
      payload: { dropResult },
    } = action;
    const { source, destination, dragging, position } = dropResult;
      Severity: Minor
      Found in superset-frontend/src/dashboard/reducers/dashboardLayout.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status