Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/dashboard/reducers/dashboardState.js

Summary

Maintainability
C
1 day
Test Coverage

Function dashboardStateReducer has 188 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function dashboardStateReducer(state = {}, action) {
  const actionHandlers = {
    [HYDRATE_DASHBOARD]() {
      return { ...state, ...action.data.dashboardState };
    },
Severity: Major
Found in superset-frontend/src/dashboard/reducers/dashboardState.js - About 7 hrs to fix

    actionHandlers has 29 functions (exceeds 20 allowed). Consider refactoring.
    Open

      const actionHandlers = {
    [HYDRATE_DASHBOARD]() {
      return { ...state, ...action.data.dashboardState };
    },
    [UPDATE_CSS]() {
    Severity: Minor
    Found in superset-frontend/src/dashboard/reducers/dashboardState.js - About 3 hrs to fix

      Function dashboardStateReducer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function dashboardStateReducer(state = {}, action) {
  const actionHandlers = {
    [HYDRATE_DASHBOARD]() {
      return { ...state, ...action.data.dashboardState };
    },
      Severity: Minor
      Found in superset-frontend/src/dashboard/reducers/dashboardState.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status