airbnb/caravel

View on GitHub
superset-frontend/src/dashboard/util/getDropPosition.js

Summary

Maintainability
D
2 days
Test Coverage

Function getDropPosition has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

export default function getDropPosition(monitor, Component) {
  const {
    depth: componentDepth,
    parentComponent,
    component,
Severity: Minor
Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDropPosition has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function getDropPosition(monitor, Component) {
  const {
    depth: componentDepth,
    parentComponent,
    component,
Severity: Major
Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 3 hrs to fix

    Avoid too many return statements within this function.
    Open

        return null;
    Severity: Major
    Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return null;
      Severity: Major
      Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return clientOffset.x < refMiddleX ? DROP_LEFT : DROP_RIGHT;
        Severity: Major
        Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return clientOffset.y < refMiddleY ? DROP_TOP : DROP_BOTTOM;
          Severity: Major
          Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  if (deltaLeft < SIBLING_DROP_THRESHOLD) return DROP_LEFT;
            Severity: Major
            Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    if (deltaRight < SIBLING_DROP_THRESHOLD) return DROP_RIGHT;
              Severity: Major
              Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return hasChildren ? DROP_BOTTOM : DROP_TOP;
                Severity: Major
                Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return null;
                  Severity: Major
                  Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          if (deltaTop < SIBLING_DROP_THRESHOLD) return DROP_TOP;
                    Severity: Major
                    Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            if (deltaBottom < SIBLING_DROP_THRESHOLD) return DROP_BOTTOM;
                      Severity: Major
                      Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return hasChildren ? DROP_RIGHT : DROP_LEFT;
                        Severity: Major
                        Found in superset-frontend/src/dashboard/util/getDropPosition.js - About 30 mins to fix

                          There are no issues that match your filters.

                          Category
                          Status