Sign upLogin

airbnb/superset

View on GitHub
Star

Showing 2,345 of 5,983 total issues

Function ChartList has 691 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function ChartList(props: ChartListProps) {
  const {
    addDangerToast,
    addSuccessToast,
    user: { userId },
Severity: Major
Found in superset-frontend/src/pages/ChartList/index.tsx - About 3 days to fix

    Function sqlLabReducer has 679 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function sqlLabReducer(state = {}, action) {
  const actionHandlers = {
    [actions.ADD_QUERY_EDITOR]() {
      const mergeUnsavedState = alterInArr(
        state,
    Severity: Major
    Found in superset-frontend/src/SqlLab/reducers/sqlLab.js - About 3 days to fix

      File api.py has 1292 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
      Severity: Major
      Found in superset/dashboards/api.py - About 3 days to fix

        Function DashboardList has 665 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function DashboardList(props: DashboardListProps) {
  const { addDangerToast, addSuccessToast, user } = props;

  const { roles } = useSelector<any, UserWithPermissionsAndRoles>(
    state => state.user,
        Severity: Major
        Found in superset-frontend/src/pages/DashboardList/index.tsx - About 3 days to fix

          File sql_parse.py has 1242 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
          Severity: Major
          Found in superset/sql_parse.py - About 3 days to fix

            File supported_charts_dashboard.py has 1232 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
            Severity: Major
            Found in superset/examples/supported_charts_dashboard.py - About 3 days to fix

              File schemas.py has 1225 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
              Severity: Major
              Found in superset/databases/schemas.py - About 3 days to fix

                File sqlLab.js has 1224 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                Severity: Major
                Found in superset-frontend/src/SqlLab/actions/sqlLab.js - About 3 days to fix

                  File FiltersConfigForm.tsx has 1184 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                  Severity: Major
                  Found in superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx - About 3 days to fix

                    File presto.py has 1146 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
                    Severity: Major
                    Found in superset/db_engine_specs/presto.py - About 2 days to fix

                      Function AlertReportModal has a Cognitive Complexity of 142 (exceeds 5 allowed). Consider refactoring.
                      Open

                      const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
  addDangerToast,
  onAdd,
  onHide,
  show,
                      Severity: Minor
                      Found in superset-frontend/src/features/alerts/AlertReportModal.tsx - About 2 days to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function transformProps has 577 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export default function transformProps(
  chartProps: EchartsMixedTimeseriesProps,
): EchartsMixedTimeseriesChartTransformedProps {
  const {
    width,
                      Severity: Major
                      Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts - About 2 days to fix

                        File data.ts has 1127 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                        Severity: Major
                        Found in superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/Area/data.ts - About 2 days to fix

                          Function Select has a Cognitive Complexity of 136 (exceeds 5 allowed). Consider refactoring.
                          Open

                            (
    {
      allowClear,
      allowNewOptions = false,
      allowSelectAll = true,
                          Severity: Minor
                          Found in superset-frontend/src/components/Select/Select.tsx - About 2 days to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function convert_filter_scopes_to_native_filters has a Cognitive Complexity of 135 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def convert_filter_scopes_to_native_filters(  # pylint: disable=invalid-name,too-many-branches,too-many-locals,too-many-nested-blocks,too-many-statements
    json_metadata: dict[str, Any],
    position_json: dict[str, Any],
    filter_boxes: list[Slice],
) -> list[dict[str, Any]]:
                          Severity: Minor
                          Found in superset/migrations/shared/native_filters.py - About 2 days to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          File api.py has 1054 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          # Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
                          Severity: Major
                          Found in superset/charts/api.py - About 2 days to fix

                            Function transformProps has 532 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            export default function transformProps(
  chartProps: EchartsTimeseriesChartProps,
): TimeseriesChartTransformedProps {
  const {
    width,
                            Severity: Major
                            Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts - About 2 days to fix

                              Function Rose has 519 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              function Rose(element, props) {
  const {
    data,
    width,
    height,
                              Severity: Major
                              Found in superset-frontend/plugins/legacy-plugin-chart-rose/src/Rose.js - About 2 days to fix

                                File NVD3Vis.js has 1018 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                /* eslint-disable react/sort-prop-types */
/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
                                Severity: Major
                                Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js - About 2 days to fix

                                  File api.py has 1006 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  # Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
                                  Severity: Major
                                  Found in superset/datasets/api.py - About 2 days to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language