Sign upLogin

airbnb/superset

View on GitHub
Star

Showing 2,345 of 5,983 total issues

Function ControlPanelsContainer has 503 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
  const { colors } = useTheme();
  const pluginContext = useContext(PluginContext);

  const prevState = usePrevious(props.exploreState);
Severity: Major
Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 2 days to fix

    Function TableChart has a Cognitive Complexity of 124 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function TableChart<D extends DataRecord = DataRecord>(
  props: TableChartTransformedProps<D> & {
    sticky?: DataTableProps<D>['sticky'];
  },
) {
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TableChart has 481 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function TableChart<D extends DataRecord = DataRecord>(
  props: TableChartTransformedProps<D> & {
    sticky?: DataTableProps<D>['sticky'];
  },
) {
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx - About 2 days to fix

      File index.tsx has 965 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
      Severity: Major
      Found in superset-frontend/src/features/databases/UploadDataModel/index.tsx - About 2 days to fix

        File Select.test.tsx has 943 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
        Severity: Major
        Found in superset-frontend/src/components/Select/Select.test.tsx - About 2 days to fix

          File core.py has 942 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
          Severity: Major
          Found in superset/models/core.py - About 2 days to fix

            File data.ts has 930 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
            Severity: Major
            Found in superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-plugin-chart-rose/data.ts - About 2 days to fix

              File AnnotationLayer.jsx has 911 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
              Severity: Major
              Found in superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx - About 2 days to fix

                File data.ts has 907 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                Severity: Major
                Found in superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/Line/data.ts - About 2 days to fix

                  File data.ts has 907 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                  Severity: Major
                  Found in superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/Compare/data.ts - About 2 days to fix

                    File data.ts has 907 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                    Severity: Major
                    Found in superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-plugin-chart-horizon/data.ts - About 2 days to fix

                      File sqlLab.test.js has 895 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                      Severity: Major
                      Found in superset-frontend/src/SqlLab/actions/sqlLab.test.js - About 2 days to fix

                        File AsyncSelect.test.tsx has 875 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                        Severity: Major
                        Found in superset-frontend/src/components/Select/AsyncSelect.test.tsx - About 2 days to fix

                          Function ExploreViewContainer has 418 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function ExploreViewContainer(props) {
  const dynamicPluginContext = usePluginContext();
  const dynamicPlugin = dynamicPluginContext.dynamicPlugins[props.vizType];
  const isDynamicPluginLoading = dynamicPlugin && dynamicPlugin.mounting;
  const wasDynamicPluginLoading = usePrevious(isDynamicPluginLoading);
                          Severity: Major
                          Found in superset-frontend/src/explore/components/ExploreViewContainer/index.jsx - About 2 days to fix

                            Function PivotTableChart has 406 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            export default function PivotTableChart(props: PivotTableProps) {
  const {
    data,
    height,
    width,
                            Severity: Major
                            Found in superset-frontend/plugins/plugin-chart-pivot-table/src/PivotTableChart.tsx - About 2 days to fix

                              File index.tsx has 836 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                              Severity: Major
                              Found in superset-frontend/src/SqlLab/components/SqlEditor/index.tsx - About 2 days to fix

                                File index.tsx has 829 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                                Severity: Major
                                Found in superset-frontend/src/pages/DatasetList/index.tsx - About 1 day to fix

                                  File index.tsx has 821 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                                  Severity: Major
                                  Found in superset-frontend/src/pages/ChartList/index.tsx - About 1 day to fix

                                    Function AsyncSelect has a Cognitive Complexity of 97 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                      (
    {
      allowClear,
      allowNewOptions = false,
      ariaLabel,
                                    Severity: Minor
                                    Found in superset-frontend/src/components/Select/AsyncSelect.tsx - About 1 day to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    File TableRenderers.jsx has 813 lines of code (exceeds 250 allowed). Consider refactoring.
                                    Open

                                    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
                                    Severity: Major
                                    Found in superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx - About 1 day to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language