Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js

Summary

Maintainability
F
2 wks
Test Coverage

Function nvd3Vis has a Cognitive Complexity of 294 (exceeds 5 allowed). Consider refactoring.
Open

function nvd3Vis(element, props) {
  const {
    data,
    width: maxWidth,
    height: maxHeight,
Severity: Minor
Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js - About 6 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function nvd3Vis has 823 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function nvd3Vis(element, props) {
  const {
    data,
    width: maxWidth,
    height: maxHeight,
Severity: Major
Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js - About 4 days to fix

    Function drawGraph has 739 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const drawGraph = function drawGraph() {
    const d3Element = d3.select(element);
    d3Element.classed('superset-legacy-chart-nvd3', true);
    d3Element.classed(`superset-legacy-chart-nvd3-${kebabCase(vizType)}`, true);
    let svg = d3Element.select('svg');
    Severity: Major
    Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js - About 3 days to fix

      File NVD3Vis.js has 1018 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* eslint-disable react/sort-prop-types */
/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
      Severity: Major
      Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js - About 2 days to fix

        Consider simplifying this complex logical expression.
        Open

                if (annotationData) {
          // Event annotations
          activeAnnotationLayers
            .filter(
              x =>
        Severity: Critical
        Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js - About 2 hrs to fix

          Function applyYAxisBounds has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              const applyYAxisBounds = () => {
      if (
        chart.yDomain &&
        Array.isArray(yAxisBounds) &&
        yAxisBounds.length === 2
          Severity: Minor
          Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                        for (let x = xMin; x < xMax; x += period) {
              xValues.push(x);
            }
            Severity: Major
            Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  svg
      .datum(data)
      .transition()
      .duration(500)
      .attr('height', height)
              Severity: Minor
              Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js and 1 other location - About 50 mins to fix
              superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js on lines 915..921

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                            const annotations = d3
                .select(element)
                .select('.nv-wrap')
                .append('g')
                .attr('class', `nv-interval-annotation-layer-${index}`);
              Severity: Minor
              Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js and 1 other location - About 50 mins to fix
              superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js on lines 1026..1030

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    svg
        .datum(data)
        .transition()
        .duration(500)
        .attr('width', width)
              Severity: Minor
              Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js and 1 other location - About 50 mins to fix
              superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js on lines 700..706

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                            const annotations = d3
                .select(element)
                .select('.nv-wrap')
                .append('g')
                .attr('class', `nv-event-annotation-layer-${index}`);
              Severity: Minor
              Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js and 1 other location - About 50 mins to fix
              superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js on lines 1104..1108

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        activeAnnotationLayers
            .filter(
              x =>
                x.annotationType === ANNOTATION_TYPES.EVENT &&
                annotationData &&
              Severity: Minor
              Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js and 1 other location - About 35 mins to fix
              superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js on lines 1094..1185

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        activeAnnotationLayers
            .filter(
              x =>
                x.annotationType === ANNOTATION_TYPES.INTERVAL &&
                annotationData &&
              Severity: Minor
              Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js and 1 other location - About 35 mins to fix
              superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js on lines 1016..1091

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status