Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/src/explore/reducers/exploreReducer.js

Summary

Maintainability
D
2 days
Test Coverage

Function exploreReducer has 249 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function exploreReducer(state = {}, action) {
  const actionHandlers = {
    [DYNAMIC_PLUGIN_CONTROLS_READY]() {
      return {
        ...state,
Severity: Major
Found in superset-frontend/src/explore/reducers/exploreReducer.js - About 1 day to fix

    Function exploreReducer has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function exploreReducer(state = {}, action) {
  const actionHandlers = {
    [DYNAMIC_PLUGIN_CONTROLS_READY]() {
      return {
        ...state,
    Severity: Minor
    Found in superset-frontend/src/explore/reducers/exploreReducer.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function actions.SET_FIELD_VALUE has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        [actions.SET_FIELD_VALUE]() {
      const { controlName, value, validationErrors } = action;
      let new_form_data = { ...state.form_data, [controlName]: value };
      const old_metrics_data = state.form_data.metrics;
      const new_column_config = state.form_data.column_config;
    Severity: Major
    Found in superset-frontend/src/explore/reducers/exploreReducer.js - About 3 hrs to fix

      File exploreReducer.js has 263 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
      Severity: Minor
      Found in superset-frontend/src/explore/reducers/exploreReducer.js - About 2 hrs to fix

        Function actions.UPDATE_FORM_DATA_BY_DATASOURCE has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            [actions.UPDATE_FORM_DATA_BY_DATASOURCE]() {
      const newFormData = { ...state.form_data };
      const { prevDatasource, newDatasource } = action;
      const controls = { ...state.controls };
      const controlsTransferred = [];
        Severity: Minor
        Found in superset-frontend/src/explore/reducers/exploreReducer.js - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status